Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): hide all unnamed #9378

Merged
merged 4 commits into from
May 13, 2024
Merged

feat(web): hide all unnamed #9378

merged 4 commits into from
May 13, 2024

Conversation

martabal
Copy link
Member

@martabal martabal commented May 10, 2024

When you click the eye button in Show and Hide People mode, you toggle between "hiding only unnamed people", "hiding all people", "showing all people".

#5928

2024-05-10.18-55-02.mp4

Copy link

cloudflare-workers-and-pages bot commented May 10, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 91d6636
Status: ✅  Deploy successful!
Preview URL: https://dcdf51ff.immich.pages.dev
Branch Preview URL: https://feat-hide-all-unnamed.immich.pages.dev

View logs

@martabal martabal requested a review from danieldietzler May 10, 2024 17:35
@martabal martabal force-pushed the feat/hide-all-unnamed branch from 987177f to 506d522 Compare May 10, 2024 20:30
@martabal martabal force-pushed the feat/hide-all-unnamed branch from 723c71b to 91d6636 Compare May 11, 2024 19:18
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM! :)

@zackpollard zackpollard merged commit aa1dc68 into main May 13, 2024
23 checks passed
@zackpollard zackpollard deleted the feat/hide-all-unnamed branch May 13, 2024 10:17
@waclaw66
Copy link
Contributor

I've tested this PR, however it doesn't work like described for me. It only hides faces without name, that button doesn't work as toggle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants