Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sdk init #9563

Merged
merged 1 commit into from
May 17, 2024
Merged

refactor: sdk init #9563

merged 1 commit into from
May 17, 2024
+40 −19

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented May 17, 2024

  • Add a few utility functions into the typescript-sdk and use them in the cli and web projects.

@jrasm91 jrasm91 added the cli Tasks related to the Immich CLI label May 17, 2024
@jrasm91 jrasm91 requested a review from bo0tzz May 17, 2024 17:34
@jrasm91 jrasm91 requested a review from danieldietzler as a code owner May 17, 2024 17:34
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb06cc3
Status: ✅  Deploy successful!
Preview URL: https://e33af57e.immich.pages.dev
Branch Preview URL: https://refactor-sdk-init.immich.pages.dev

View logs

danieldietzler
danieldietzler approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat little improvement :)

@jrasm91 jrasm91 merged commit 136bb69 into main May 17, 2024
25 of 26 checks passed
@jrasm91 jrasm91 deleted the refactor/sdk-init branch May 17, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@alextran1502 alextran1502 alextran1502 approved these changes

@bo0tzz bo0tzz Awaiting requested review from bo0tzz

Assignees
No one assigned
Labels
cli Tasks related to the Immich CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrasm91 @alextran1502 @danieldietzler