Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Google OAuth example #9778

Merged
merged 5 commits into from
May 27, 2024
Merged

Conversation

aviv926
Copy link
Contributor

@aviv926 aviv926 commented May 26, 2024

This PR adds screenshots for Google OAuth setup.

@aviv926 aviv926 added the documentation Improvements or additions to documentation label May 26, 2024
@aviv926 aviv926 changed the title Docs:Add Google OAuth example docs: Add Google OAuth example May 26, 2024
@jrasm91
Copy link
Contributor

jrasm91 commented May 26, 2024

I think we can include the screenshot for Google cloud, but for the immich side, let's just include the example values in plain text instead, since screenshots quickly become outdated.

@aviv926
Copy link
Contributor Author

aviv926 commented May 26, 2024

I think we can include the screenshot for Google cloud, but for the immich side, let's just include the example values in plain text instead, since screenshots quickly become outdated.

Yes, it's better, I updated accordingly.

@aviv926 aviv926 requested a review from jrasm91 May 26, 2024 22:15
@jrasm91 jrasm91 merged commit e3d3983 into immich-app:main May 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants