fix: immich port with external domain #9856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
0636a54
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a54cc8b0.immich.pages.dev |
| Branch Preview URL: | https://fix-immich-port-external-dom.immich.pages.dev |
jrasm91
reviewed
May 29, 2024
server/src/constants.ts
Outdated
| @@ -24,6 +24,8 @@ export const envName = (process.env.IMMICH_ENV || 'production').toUpperCase(); | |||
| export const isDev = () => process.env.IMMICH_ENV === 'development'; | |||
| export const APP_MEDIA_LOCATION = process.env.IMMICH_MEDIA_LOCATION || './upload'; | |||
| export const WEB_ROOT = process.env.IMMICH_WEB_ROOT || '/usr/src/app/www'; | |||
| const HOST_SERVER_PORT = process.env.IMMICH_PORT || '2283'; | |||
| export const FALLBACK_EXTERNAL_DOMAIN = 'http://localhost:' + HOST_SERVER_PORT; | |||
There was a problem hiding this comment.
Can you rename this to DEFAULT_EXTERNAL_DOMAIN?
jrasm91
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the fallback for the external domain uses the
:2283port which is the wrong port if you haveIMMICH_PORTset.