feat: add support for user custom attributes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=========================================
Coverage 99.55% 99.56%
- Complexity 478 481 +3
=========================================
Files 135 135
Lines 908 913 +5
=========================================
+ Hits 904 909 +5
Misses 4 4
☔ View full report in Codecov by Sentry. |
antonioturdo
force-pushed
the
feat/custom-attributes
branch
3 times, most recently
from
2908d55
to
d974402
Compare
antonioturdo
force-pushed
the
feat/custom-attributes
branch
from
d974402
to
de0b663
Compare
| @@ -67,6 +67,8 @@ class UserAttributes extends BaseObject | |||
|
|
|||
| public ?string $twitter = null; | |||
|
|
|||
| private array $_customAttributes = []; | |||
There was a problem hiding this comment.
I dislike using "$_*" to figure out that the variable is private.
my2cent
There was a problem hiding this comment.
I used this notation to distinguish it from the real properties of the UserAttributes object expected by Braze. However, being a private detail, we can choose to rename it in the future as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Proposed changes
Add methods in the
UserAttributesclass to set custom attributes without using dynamic properties.Close #42
⚙️ Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply