analyze: CLI options #1057
Merged
analyze: CLI options #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spernsteiner
force-pushed
the
analyze-cli-options
branch
from
ad52299 to
1014136
Compare
kkysen
reviewed
Jan 10, 2024
c2rust-analyze/src/main.rs
Outdated
Comment on lines
394
to
409
| if let Some(ref fixed_defs_list) = fixed_defs_list { | ||
| cmd.env("C2RUST_ANALYZE_FIXED_DEFS_LIST", fixed_defs_list); | ||
| } | ||
|
|
||
| if let Some(ref rewrite_paths) = rewrite_paths { | ||
| cmd.env("C2RUST_ANALYZE_REWRITE_PATHS", rewrite_paths); | ||
| } | ||
|
|
||
| if rewrite_in_place { | ||
| cmd.env("C2RUST_ANALYZE_REWRITE_IN_PLACE", "1"); | ||
| } | ||
|
|
||
| if use_manual_shims { | ||
| cmd.env("C2RUST_ANALYZE_USE_MANUAL_SHIMS", "1"); | ||
| } |
There was a problem hiding this comment.
If we plan on continually adding more args over time, we could just serialize Args, pass that to the rustc wrapper, and deserialize them all at once there, rather than having new (simple, but slightly different for each) logic for each arg.
aneksteind
approved these changes
Jan 18, 2024
spernsteiner
force-pushed
the
analyze-cli-options
branch
from
1014136 to
4ab214c
Compare
spernsteiner
force-pushed
the
analyze-cli-options
branch
from
4ab214c to
faa795d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes some configuration options that were previously controlled by environment variables as command-line options for the cargo wrapper, and also adds a few new options:
--rewrite-in-place: Overwrite source files with the results of rewriting--rewrite-paths: Only rewrite defs whose paths start with a string from this list--use-manual-shims: When shims can't be generated, emit atodo!()placeholder for manual editing instead of failing--fixed-defs-list: Read a list of defs from this file and mark each one asFIXED