Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LLVM18 #1067

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add support for LLVM18 #1067

merged 2 commits into from
Mar 13, 2024

Conversation

thedataking
Copy link
Contributor

@thedataking thedataking commented Mar 13, 2024

Notes:

  • Main breakage due to addition of clang::StringLiteralKind enum and addition of a new clang module: clangAPINotes.
  • There doesn't seem to be a 18.0.0 release at this time
  • scripts/test_transpiler.py encountered some failures.
  • Disabled zstd support and various tests to avoid assorted configure and linker errors.
  • Ripped out the last vestiges of xcode support which must terribly bitrotted by now.

Closes #1066.

@thedataking thedataking requested a review from fw-immunant March 13, 2024 00:46
Notes:
- Main breakage due to addition of `clang::StringLiteralKind` enum
  and addition of a new clang module: `clangAPINotes`.
- There doesn't seem to be a 18.0.0 release at this time
- `scripts/build_transpiler.py` doesn't build 18.1.1 cleanly
- `scripts/test_transpiler.py` encountered test failures.
- There is an unresolved linker error from `libzstd` on macOS.

Closes #1066.
@thedataking thedataking force-pushed the feature/llvm-18.1.1 branch from fcd8e17 to 34ac036 Compare March 13, 2024 00:50
Copy link
Contributor

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I can't validate anything about XCode/macOS workflows outside of the fact that our Darwin CI still seems happy.

@thedataking thedataking merged commit c6b5bc0 into master Mar 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with LLVM 18 and tip-of-tree
2 participants