Construct PDG exclusively on provenance information #1107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahomescu
force-pushed
the
ahomescu/provenance_only_pdg
branch
5 times, most recently
from
bd3986b to
a71b395
Compare
Record field and index projections for pointers by recording a Project event with a base and target pointer pair.
Add an index value to Project events to differentiate between different projections with the same pointer offset, e.g., (*p).x and (*p).x.a if a is the first field of the structure. This is implemented as an IndexSet<Vec<usize>> where each element is a unique combination of field projections. The Project index points to an element in this set.
The event assignment-based PDG construction steps were giving incorrect results for indirect accesses, so remove them completely.
ahomescu
force-pushed
the
ahomescu/provenance_only_pdg
branch
from
a71b395 to
77cbeb3
Compare
ahomescu
force-pushed
the
ahomescu/provenance_only_pdg
branch
from
77cbeb3 to
9b94bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a split of the first few commits of #1086 so it can be reviewed and landed faster.