fix typos #1192
Open
fix typos #1192
+44
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
previously approved these changes
Dec 20, 2024
fw-immunant
requested changes
Dec 20, 2024
| @@ -752,7 +752,7 @@ impl<'c> Translation<'c> { | |||
| // Extract expression | |||
| let in_expr = in_expr.map(|(i, operand)| (i, operand.expression)); | |||
|
|
|||
| // For inouts, change the dirspec to include 'in' | |||
There was a problem hiding this comment.
NAK. An inout is not an input, it's a bidirectional (in and out) argument; see above where we also mention that we are handling inout arguments.
There was a problem hiding this comment.
Oh whoops I didn't see that.
|
I have also added a .typos.toml , config for https://crates.io/crates/typos-cli ; happy to remove if not desired, or move into a .config/ in order to reduce top level files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.