Disarm C's doc comments even inside lines #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes-To: immunant#310
As C-style comments are aggregated to the point where translate_comment receives input like `/**********//*********/`, the per-line processing that reliably removes `///` and `//!` before expressing the comments in Rust (where a doc comment may not be legal at a given position) failed to catch input like the above that needed `/**` replaced with `/* *` twice, and not only at the start of the line. Closes: immunant#310
|
Still merges cleanly into master and works fine. Can the CI be retriggered? Or should this be rebased? |
|
With the (harder-to-solve) ASM issues are slowly becoming obsolete, I'd like to push on the easy PRs so that RIOT (once having worked around the remaining assembly) can be built using an upstream C2Rust. What's the status on this, is there anything that needs fixing on the CI side, or should I just rebase my PR onto master and try again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward fix for #310, accompanied by an extension to the test cases to cover the new behavior. The new test failed with the old code, and now passes.
edit for github's automatism that doesn't get the information from the individual commits: Closes #310