Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix webpack config interpreting cjs files as assets #111

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix webpack config interpreting cjs files as assets #111

merged 1 commit into from
Nov 16, 2023

Conversation

jason-crow
Copy link

@jason-crow jason-crow commented Nov 16, 2023 •
edited by aruniverse
Loading

  • the current webpack.config.js would interpret .cjs files as assets preventing them from being loaded as source
  • solution was to amend the rule for asset/resource to exclude .cjs files
  • this issue came up because in the newer axios versions are configured to pull the source as .cjs for requires from a browser
  • see 🚑 webpack - loading cjs as an asset instead of source

aruniverse
aruniverse approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stupid axios

@aruniverse aruniverse merged commit a70eff9 into imodeljs Nov 16, 2023
1 of 10 checks passed
@aruniverse aruniverse deleted the fix/webpack-resource-exclude-cjs branch November 16, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse approved these changes

@wgoehrig wgoehrig Awaiting requested review from wgoehrig wgoehrig is a code owner

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-crow @aruniverse