Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: how to specify a default while specifying granular extensions? #390

Closed
ljharb opened this issue Jun 21, 2016 · 7 comments
Closed

Comments

@ljharb
Copy link
Member

ljharb commented Jun 21, 2016

I'd like the default to be "always" but i'd like js and jsx to be "never". How do I specify this? The schema only allows a string, or an object, but not both.

@ljharb
Copy link
Member Author

ljharb commented Jun 21, 2016

(Similarly, I should be able to specify "never" and have a specific extension be "always")

It's not clear to me how to ensure that.

@benmosher
Copy link
Member

Ah, interesting. I'm not sure how you'd do that, either. Sounds like a reasonable goal though.

@ljharb
Copy link
Member Author

ljharb commented Jun 21, 2016

My thinking was that the schema would allow a string and an object - the string constitutes the default, and the object has granular overrides.

@ljharb
Copy link
Member Author

ljharb commented Aug 1, 2016

Any update on this?

@benmosher
Copy link
Member

I like your proposal:

... the schema would allow a string and an object - the string constitutes the default, and the object has granular overrides.

Don't think it constitutes a breaking change, since the first arg can still be a string or object, but the second one must be an object if the first is a string, and the second must not be provided if the first is an object.

I'm not planning on working on this anytime soon. I'd be happy to accept and ship a PR, though.

@ljharb
Copy link
Member Author

ljharb commented Sep 12, 2016

Finally filed #555 to fix this :-)

@ljharb
Copy link
Member Author

ljharb commented Sep 20, 2016

Yay, thanks! Waiting patiently now for the release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants