fix(dynamic-import-chunkname): Add proper webpack comment parsing #1163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As briefly discussed in #1130, current webpack comment parsing logic (without taking styling into account) is severely flawed, reporting valid comments as errors while also allowing invalid syntax.
This PR adds
Styling requirements have not been relaxed by these changes.
The main topic of #1130 - allowing single quotes in strings in webpack comments - will be implemented on top of these changes once they are merged.