Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint to version 3.0.0 🚀 #404

Merged
merged 5 commits into from
Jul 3, 2016
Merged

Update eslint to version 3.0.0 🚀 #404

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81c3701
chore(package): update eslint to version 3.0.0
greenkeeperio-bot Jul 1, 2016
f1c420e
add ESLint 3.x to valid peer dependency version range
benmosher Jul 2, 2016
7142571
bump to v1.10.1
benmosher Jul 2, 2016
cc17f48
allow ESLint 3.x as dev dep (thanks, @Starefossen, for noticing!)
benmosher Jul 2, 2016
759e305
typo fix (thanks @jfmengels)
benmosher Jul 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel

## [Unreleased]


## [1.10.1] - 2016-07-02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be 1.11.0 since it's a new thing, not a bugfix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking 1.10.1 because there are no new features, only difference is (officially declared) compatibility with ESLint 3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a new feature.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a new feature but not for the public API exposed by the eslint-plugin-import package which is what SemVer applies to in this instance.

On 3. juli 2016, at 17:10, Jordan Harband notifications@github.com wrote:

In CHANGELOG.md:

@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel

[Unreleased]

+## [1.10.1] - 2016-07-02
That is a new feature.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peerDependency list is part of the public API exposed by any package, since it requires explicit developer interaction (manually installing + updating the peer dependency).

### Added
- Officially support ESLint 3.x. (peerDependencies updeted to `2.x - 3.x`)

## [1.10.0] - 2016-06-30
### Added
- Added new rule [`no-restricted-paths`]. ([#155]/[#371], thanks [@lo1tuma])
Expand Down Expand Up @@ -297,7 +302,8 @@ for info on changes for earlier releases.
[#119]: https://github.com/benmosher/eslint-plugin-import/issues/119
[#89]: https://github.com/benmosher/eslint-plugin-import/issues/89

[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v1.10.0...HEAD
[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v1.10.1...HEAD
[1.10.1]: https://github.com/benmosher/eslint-plugin-import/compare/v1.10.0...v1.10.1
[1.10.0]: https://github.com/benmosher/eslint-plugin-import/compare/v1.9.2...v1.10.0
[1.9.2]: https://github.com/benmosher/eslint-plugin-import/compare/v1.9.1...v1.9.2
[1.9.1]: https://github.com/benmosher/eslint-plugin-import/compare/v1.9.0...v1.9.1
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-import",
"version": "1.10.0",
"version": "1.10.1",
"description": "Import with sanity.",
"main": "lib/index.js",
"directories": {
Expand Down Expand Up @@ -48,7 +48,7 @@
"chai": "^3.4.0",
"coveralls": "^2.11.4",
"cross-env": "^1.0.7",
"eslint": "2.x",
"eslint": "3.x",
"eslint-import-resolver-node": "file:./resolvers/node",
"eslint-import-resolver-webpack": "file:./resolvers/webpack",
"glob": "^6.0.2",
Expand All @@ -62,7 +62,7 @@
"rimraf": "2.5.2"
},
"peerDependencies": {
"eslint": "2.x"
"eslint": "2.x - 3.x"
},
"dependencies": {
"builtin-modules": "^1.1.1",
Expand Down