Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #939 by adding .mjs to stock Node resolver #955

Merged
merged 1 commit into from
Oct 20, 2017
Merged

fix #939 by adding .mjs to stock Node resolver #955

merged 1 commit into from
Oct 20, 2017

Conversation

benmosher
Copy link
Member

I'm assuming this is not controversial but thought it'd be good to run it through CI and get feedback just in case.

@benmosher benmosher requested a review from ljharb October 19, 2017 10:58
@coveralls
Copy link

coveralls commented Oct 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 94.726% when pulling 32133d5 on mjs into 275f1eb on master.

@benmosher
Copy link
Member Author

canceled the OSX builds until I'm able to rebase onto ci-cleanup

ljharb
ljharb approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should probably also add a pair of files for "default export only", and later when node figures out the plan there, we can add a "default + named" pair.

@coveralls
Copy link

coveralls commented Oct 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.032% when pulling 714b4c8 on mjs into 1e3f842 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.032% when pulling 714b4c8 on mjs into 1e3f842 on master.

@benmosher benmosher merged commit 98acd6a into master Oct 20, 2017
@benmosher benmosher deleted the mjs branch October 20, 2017 11:11
@renovate renovate bot mentioned this pull request Feb 22, 2018
Merged
@renovate renovate bot mentioned this pull request Mar 22, 2018
Merged
@ljharb ljharb mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmosher @coveralls @ljharb