Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Refactor: Update recurring support for PayPal Donations #153

Merged
merged 7 commits into from
Apr 6, 2023

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Apr 4, 2023

Description

This PR updates the recurring implementation of the PayPal Donations gateway (now that recurring support is available in the develop branch of next gen).

  • PayPal Provider Script is now set to defer loading.
  • Extracted a <PaymentMethodsWrapper/> component for observing form changes.
  • Visually hide Hosted Fields when not supported (prevent re-mounting error).
  • Smart Buttons now conditionally set createOrder() or createSubscription().

Visuals

image

Testing Instructions

Toggle between one-time/recurring donations.
The PayPal Donations gateway should not throw an error.

@jonwaldstein
Copy link
Contributor

@kjohnson when I click the PayPal button for a recurring donation the request fails. Can you please confirm this gateway is functional when submitting a recurring donation.

@kjohnson
Copy link
Member Author

kjohnson commented Apr 4, 2023

image

@kjohnson kjohnson merged commit 33dd440 into develop Apr 6, 2023
@kjohnson kjohnson deleted the refactor/paypal-donations-recurring branch April 12, 2023 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants