Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Refactor: update base styles to support custom fields #187

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jun 1, 2023

Description

This updates the base form design styles to utilize css grid with gap to account for spacing of custom fields.

This was most noticeable on multistep form with some fields using margin and others using gap. So using grid by default gives even spacing between fields and allows custom form designs to further customize.

Affects

The base form design styles

Visuals

Before

Screenshot 2023-06-01 at 12 52 34 PM

After

Screenshot 2023-06-01 at 12 48 26 PM

Testing Instructions

  • Pull branch and run npm run dev
  • Add some custom fields and switch between form designs
  • Make sure the spacing looks acceptable.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein requested review from pauloiankoski and removed request for pauloiankoski June 1, 2023 16:53
@jonwaldstein
Copy link
Contributor Author

@pauloiankoski small one, ready for review.

Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonwaldstein jonwaldstein merged commit 6b33761 into develop Jun 1, 2023
@jonwaldstein jonwaldstein deleted the refactor/base-styles branch June 1, 2023 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants