Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Refactor: Reorganize Form Header controls #229

Merged
merged 10 commits into from
Aug 4, 2023

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jul 26, 2023

Description

This PR reorders the Header, Heading and Description toggle controls related to the Visual Form Builders Header component. The Reorder was requested to be updated per design and also allows these controls to determine whether or not to show the related TextControls.

In addition, the Form Builder blocks with icons have had their corresponding svg elements replaced with the SVG & Path components provided by WordPress and the NextGen blocks have an updated fill color of currentColor so that the icons are visible when selected from the icon list.

And lastly the Text block has had its title renamed to "Text Field"

Affects

Design section Header controls & Block Icons.

Visuals

Screen.Recording.2023-07-26.at.8.21.49.AM.mov

TextField:
Screen Shot 2023-07-25 at 7 34 18 PM

Testing Instructions

  • Click on a section block from the left menu to verify that it is visible when the selected background changes.
  • Verify all icons still function properly.
  • View new order of Header controls and test that the toggle controls show &/or hide the corresponding TextControls.
  • Verify updated Text Field title.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit 19ae8ec into develop Aug 4, 2023
16 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the fix/header-heading-controls branch August 7, 2023 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants