This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor: Update Terms & Conditions block showInForm
display
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaHungDinh
changed the title
Refactor: Update Terms & Conditions block
Refactor: Update Terms & Conditions block Aug 1, 2023
in form
displayshowInForm
display
pauloiankoski
approved these changes
Aug 3, 2023
rickalday
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the "In form" agreement text display style for the Terms and conditions block. This display type originally was setup similar to the original agreement text for v2 forms, in where a user would need to open/reveal the agreement by clicking a show terms button. We have updated this by removing the "show terms" button and displaying the agreement text initially without the need to open/reveal it.
Additional updates include:
Checkbox
function name toCheckboxPlaceholder
to improve readabillityAffects
Terms & Conditions block
Visuals
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks