Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Fix: offline donation setting #250

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix: offline donation setting #250

merged 1 commit into from
Aug 14, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Aug 14, 2023 •
edited
Loading

Description

  • Replace setting control because of button not showing up
  • Update form setting key because of using wrong key
  • Update default value conditional because content was empty

Affects

Offline donation setting

Visuals

Screenshot 2023-08-14 at 11 45 10 AM

Testing Instructions

  • Test the offline donation instructions setting in the form builder

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

fix: replace control because of button not showing up, update form se…
14b7809 
…tting key because of using wrong key, update default value conditional because it was empty
kjohnson
kjohnson approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this - looks good to me.

@kjohnson kjohnson merged commit b35d296 into develop Aug 14, 2023
16 checks passed
@jonwaldstein jonwaldstein deleted the fix/offline-donation-instructions branch August 14, 2023 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kjohnson kjohnson kjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonwaldstein @kjohnson