Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Tests: add unit test workflow #72

Merged
merged 35 commits into from
Nov 1, 2022
Merged

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Oct 21, 2022

Resolves #73

Description

This PR implements a workflow to automatically run the PHPUnit tests of the add-on.

For now, the tests aren't passing because one is failing in every scenario and others are failing just with PHP 8.

So, for a temporary test, I edited the test that is failing in all scenarios just to check how the workflow will work.

And here is the result: https://github.com/impress-org/givewp-next-gen/actions/runs/3297201959/jobs/5437950344

Affects

The "push" and "pull request" operations for this repository.

Visuals

image

Testing Instructions

Just push something (or open a pull request like this) to the develop or master branches

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Oct 21, 2022
@glaubersilva glaubersilva marked this pull request as ready for review October 21, 2022 19:21
@impress-org impress-org deleted a comment from github-actions bot Oct 25, 2022
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaubersilva great work!

I updated this PR to:

  1. Re-arrange the order of the steps slightly so that we're checking out both the repositories first
  2. Added a step to setup node and run the build process - I found this was needed for feature tests.
  3. Updated any failing unit Tests

At this point i'll move the workflow yml file into our github actions repo and then just reference it here.

@jonwaldstein jonwaldstein changed the title Feature: add tests workflow Tests: add unit test workflow Nov 1, 2022
@jonwaldstein jonwaldstein merged commit c71827f into develop Nov 1, 2022
@jonwaldstein jonwaldstein deleted the feature/include-tests-workflow branch November 1, 2022 17:39
@glaubersilva
Copy link
Contributor Author

@jonwaldstein Great! Glad to see it working. =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated unit tests to add-on repos
2 participants