List of issues to revisit at the end of merging dev branch

[henrikingo]

I will use this ticket as a notepad of issues that have been pointed out during the series of PRs into the dev branch, that I intend to return to do (or at least discuss) later, once all of my fork has been merged over. Each bullet point can be broken out as a separate issue later (or just do it).

• All new plugins lack test coverage
• Add documentation how to write tests (e.g. explain the approach with the iframe, where to add tests...)
• Add an entry in circle.yml that checks that js/impress.js does in fact contain the output of build.js (Check that developer remembered to do node build.js before git commit.)
• Change gc.addCallback to gc.pushCallback
• Btw, gc library could be refactored so that the different types of objects pushed go into the same stack, and are iterated together in teardown, not separately by type.
• Create a ticket for introducing jsdoc for API / code documentation
• Move to uglify-es to support ES6 for minified impress.min.js compilation
• Discuss: Can we remove the code that attempts to support more than one root element per window/frame? A lot of other code, such as getElementFromHash (or key navigation plugin) doesn't really support it anyway.
• bower.json: Is this file still up to date? Is it needed? Do we upload a bower package somewhere?
• karma.conf-sauce.js: Safari and IE didn't work with the new iframe based approach to testing. Figure out if there's some option one can use to allow javascript to access the DOM inside the iframe.
• karma.conf-sauce.js should share the files: and proxies: sections with karma.conf.js so that they don't need to be updated in 2 places

[bartaz]

I was thinking about something like this. Thanks for creating it!

[FagnerMartinsBrack]

I have edited the comment to convert to checkboxes and add some inline code markup, hope you don't mind.

Create a ticket for introducing jsdoc for API / code documentation

To that point, we should probably take some care to not tell what the code does internally in the form of comments. I see the value of using JSDocs for plugin documentation.

You might also be interested in checking out doclets.io for that matter.

[henrikingo]

Created: #657 #658 #659 #660 #661 #662 #663 #664 #665 #666

Closing this issue.