Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide cursor in fullscreenafter a configured delay without movement #388

Closed
wants to merge 4 commits into from

Conversation

sclausen
Copy link

For making presentations better, it would be great, if the mouse cursor hides after going to fullscreen.
This commit implements this behavior.

@FagnerMartinsBrack
Copy link
Member

FagnerMartinsBrack commented Feb 14, 2016

Hi @sclausen, in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.

To give a little bit of context, recently a decision was made in the project to make the development more active and the first task is to clear up older PRs like this one to see if the OP is still interested in keep it going.

@Pierstoval
Copy link
Contributor

This feature should be enabled/disabled by the developer to avoid behavior misunderstanding. Even if I like the feature I'd set it to off by default

@FagnerMartinsBrack
Copy link
Member

Closing due to the lack of feedback from the OP. If you want to work in the PR again, feel free to comment here to open up the discussion again

As this feature seems to be pretty useful I have created a new issue to track it: #527

@sclausen
Copy link
Author

sclausen commented Mar 5, 2016

@FagnerMartinsBrack sorry for the long delay, but I didn't know how to properly respond. Sure I didn't track this issue, because it has been so very very long ignored. So, what should or could be done now?

@FagnerMartinsBrack
Copy link
Member

@sclausen
Are you willing to rebase/fix code review/etc if asked to do so? If yes, then I will reopen as stated in the last comment.

@sclausen
Copy link
Author

sclausen commented Mar 5, 2016

Sure I'll do.

@sclausen sclausen changed the title hide the mouse cursor in fullscreenmode after 3 seconds without movement hide the mouse cursor in fullscreenmode after a configured amount of milliseconds without movement Mar 10, 2016
@sclausen sclausen changed the title hide the mouse cursor in fullscreenmode after a configured amount of milliseconds without movement hide cursor in fullscreenafter a configured delay without movement Mar 10, 2016
@sclausen
Copy link
Author

@FagnerMartinsBrack weren't my changes good to merge?

@FagnerMartinsBrack
Copy link
Member

@sclausen I'm sorry, I have no idea why this was closed o.O.

@FagnerMartinsBrack
Copy link
Member

Oh, looking again it seems that this was closed automatically by Github because the dev branch was removed (this PR was opened against the dev branch). See #521 for context.

Can this be opened against master? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants