Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Added license, updated Readme and added Changelog file #511

Merged
merged 3 commits into from
Feb 3, 2016
Merged

[Doc] Added license, updated Readme and added Changelog file #511

merged 3 commits into from
Feb 3, 2016

Conversation

Pierstoval
Copy link
Contributor

Ping @impress/mergers for review

@Pierstoval
Copy link
Contributor Author

@bartaz I made fb0f882 to fix your comments. Could you reply only in the PR ("Files changed" tab, and not the commit itself) to keep the diff/notes up to date to your needs? :)

@bartaz
Copy link
Member

bartaz commented Feb 2, 2016

@Pierstoval sure, I wasn't aware that these comments are not shared across commit and files changed pages. They still appear there in PR thread.

Released under the MIT and GPL (version 2 or later) Licenses.


Copyright 2011-2016 Bartek Szopka - [Licence](LICENCE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes. Still, make clear that license is MIT in readme, so people don't need to look into license file just to know that. So make it Released under the MIT [License](LICENSE). - note the typo in file name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a33f2ec !

@FagnerMartinsBrack
Copy link
Member

The good thing in comment on the "Files Changed" tab is that Github shows a part of the snippet and all comments below it in the timeline

@Pierstoval
Copy link
Contributor Author

The good thing in comment on the "Files Changed" tab is that Github shows a part of the snippet and all comments below it in the timeline

And when a line of code is changed, the note appears as outdated diff instead of a global note 😉

bartaz added a commit that referenced this pull request Feb 3, 2016
Cleaning up the docs - Added license, updated Readme and added Changelog file
@bartaz bartaz merged commit d277f54 into impress:master Feb 3, 2016
@Pierstoval Pierstoval deleted the license_doc branch February 3, 2016 07:44
@FagnerMartinsBrack FagnerMartinsBrack mentioned this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants