Attempt to make test_generators more robust #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that this particular test trips if the output is reference histogram is generated on an M1 Mac. For a previous PR I regenerated it on the thread ripper and then it passed on both. I'll try it and if the tests pass merge before the impy->chromo PR since most changes here are for binaries. |
|
No, don't bother. It is not practical if I cannot generate the reference myself. I think we should rather skip that test. Besides, I think we should generally skip test_generators on Windows, where it takes much longer than on Macos and Linux. |
|
Ok, agree. Regarding windows, it seems to be related to hepmc. These tests take much longer than on *nix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reduced the binning of the histograms used by test_generators in an attempt to make the test more robust against the issue we observed in #112
Unfortunately, it does not work. We should just skip the affected UrQMD test.