Add support for more operating systems. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangxp1998
requested changes
Jan 12, 2020
|
O(∩_∩)O Thanks for sending a PR! Overall looks good, I left one knitpick. |
|
Also please correct the CI failure, it seems to be some formatting issue. Just format your code with |
This commit will add support for operating systems that have the lsof tool, initially it will only work on MacOS and FreeBSD, but more operating systems may be added at a later time. Signed-off-by: Valdemar Erk <valdemar@erk.io>
|
I have made the changes you requested |
|
Missed one of the places so that is the reason for the other force push. |
zhangxp1998
approved these changes
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will add support for other bsd like systems then
macos, I am not able to test on macos, but I can confirm that
it works on freebsd. it should also work on other systems with
lsof, if I understand how it works correctly. wich according to the
man pages includes macos, freebsd, linux and solaris.
Closes #20