Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dns): fixup "Error parsing resolv.conf: InvalidOption(17)" error #215

Closed
wants to merge 1 commit into from

Conversation

ttys3
Copy link

@ttys3 ttys3 commented Mar 24, 2021

update 2023-01-20: this PR has been superseded by #262

This error because trust-dns-resolver 0.18.x use the old resolv-conf 0.6.x

❯ bandwhich -V
bandwhich 0.20.0
❯ bandwhich
Error: Could not initialize the DNS resolver. Are you offline?

Reason: ResolveError { inner: Custom { kind: Other, error: "Error parsing resolv.conf: InvalidOption(17)" }

io error }

with systemd-resolved we have the /etc/resolv.conf like this which will trigger the error.

nameserver 127.0.0.53
options edns0 trust-ad

@Congee
Copy link

Congee commented Mar 27, 2021

ping

@jgauth
Copy link

jgauth commented Apr 1, 2021

I had the same issue - confirming that this PR does fix the issue for me.

@ttys3
Copy link
Author

ttys3 commented Jun 5, 2021

@imsnif

@Ma27
Copy link
Contributor

Ma27 commented Jun 30, 2021

I can also confirm that this fixes the most recent issues I observed.

@adamroyjones
Copy link

I'm also affected by this. Your branch fixes the issue for me—thanks.

Copy link
Contributor

@kpcyrd kpcyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on a ubuntu 20.04 system, the binary you currently get with cargo install bandwhich didn't work on my system, this branch does.

@ttys3
Copy link
Author

ttys3 commented Jan 20, 2023

I upgrade dep crates to the latest version. and released a new version for myself usage.
it is under: https://github.com/ttys3/bandwhich/releases/tag/0.20.1

there still tests problem. when the tests issue migrated, I think I could make another PR.

see https://github.com/ttys3/bandwhich/commits/0.20.1

@ttys3
Copy link
Author

ttys3 commented Jan 20, 2023

in favor of #262

close this

@ttys3 ttys3 closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants