Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc dependency upgrades #265

Closed
wants to merge 5 commits into from

Conversation

jcgruenhage
Copy link
Contributor

Upgrades nearly all dependencies, separated into a few chunks:

  • socket2: Required for Rust 1.64+, because of Implement network primitives with ideal Rust layout, not C system layout rust-lang/rust#78802
  • tokio: Tokio now has a stable release, let's use that. Also required updating trust-dns-resoler, and in the dpendency chain we also had failure replaced with anyhow/thiserror, so I've also done that for bandwhich here.
  • tui and crossterm
  • pnet and ipnetwork
  • everything that was possible to upgrade without actually touching the code.

I've skipped updating procfs for now, because the API change here wasn't as straight-forward to port as the rest.

This fixes #263.

Only blocker right now: hughesac/packet_builder#5

@jounathaen
Copy link

jounathaen commented Jul 3, 2023

I can confirm, that this fixes #263
Hint for people that need a hotfix for a working bandwhich version:

cargo install --git https://github.com/jcgruenhage/bandwhich --branch=upgrades-2023-04-11

@stappersg
Copy link

After doing

git remote add jcgruenhage https://github.com/jcgruenhage/bandwhich
git fetch jcgruenhage
git checkout upgrades-2023-04-11

I was able to do

cargo build

succesfully.

@colemickens
Copy link

It'd be great to see this merged in some form. This tool is unusable on all my computers without these bumps.

@cyqsimon
Copy link
Collaborator

See #275

@cyqsimon cyqsimon closed this Aug 25, 2023
@jounathaen
Copy link

I'm confused now. Why is this PR closed? Isn't it exactly in line with what you wrote in #275 that "PRs are more than welcome though"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No such device (os error 19)
5 participants