Display 30 chars for process name #63
Conversation
|
I like this! I'll give it a full review a little later, but for now - do you think we can get rid of the extra chars somehow (eg. |
|
Re \x20: Looks like lsof automatically escape space characters into “\x20”. We can “unescape” it, but there might be other characters that lsof is escaping. |
|
lsof escapes anything for which iswprint() returns false, as well as backslash. It supports a large variety of escaping schemes - may be annoying to undo. Especially since both \x03 and ^C are printed as ^C. (^? will never be printed on x86, since char is signed, so (unsigned)(char)-1 is 0xFFFFFFFF. But it will show up on ARM. Fun.) |
Strange that it treats the space character as non printable. Maybe we can simply replace all \x20 with space characters? Other escaped chars are probably non-printable, we should leave them alone. |
zhangxp1998
force-pushed
the
procname
branch
2 times, most recently
from
c1b54bb to
ff16687
Compare
|
Now it looks like: |
|
Oh, you're right. Space is indeed printable per isprint(); I misread the code. Space is another special case, alongside backslash. I agree with leaving escaped unprintables as is, and unescaping space. Backslash should probably be unescaped too, to make Wine programs look better (though lsof seems to not print their paths?). |
src/os/lsof_utils.rs
Outdated
| @@ -62,7 +62,7 @@ impl RawConnection { | |||
| } | |||
|
|
|||
| pub fn get_connections<'a>() -> RawConnections { | |||
| let content = run(&["-n", "-P", "-i4"]); | |||
| let content = run(&["-n", "-P", "-i4", "+c", "30"]); | |||
There was a problem hiding this comment.
When I do lsof -n -P -i4 +c 30 on my machine, I get lsof: +c 30 > what system provides (15)
I looked through the lsof man page and under the +c w section, I found this: "If w is zero ('0'), all command characters supplied to lsof by the UNIX dialect will be printed"
What do you think about changing "30" to "0"? That way we just get the max possible value on each machine?
There was a problem hiding this comment.
If our UI will correctly truncate the string to size of user's terminal, sure. (What if the process name is too long that it overflows display)
There was a problem hiding this comment.
Hmm looks like most processes on my machine have names < 15 chars, I don't think that will be a problem for many people. Let me update the code
There was a problem hiding this comment.
Also - we should truncate them in the UI. I think it already does that with the connection strings, which are horribly long. :)
|
LGTM - thanks for another great PR @zhangxp1998 :) |
bandwhich uses
lsofto obtain process names. On MacOS,lsofdefaults to only showing first 9 characters of process names.This is slightly confusing sometimes, for example, in the above screenshot, what is "Google"? I think we should tweek lsof to display more characters. (30 in this commit)
After: