Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code): Add error message suggesting sudo if permission error (#59) #67

Merged

Conversation

Tobbeman
Copy link
Contributor

@Tobbeman Tobbeman commented Jan 3, 2020

I decided to use a nested match statement for further handling
of the error, since it appears to be more rustesqe than a
if statement.

This closes #59

Note
I do not appear to need to run with sudo anymore, maybe this is no longer needed?
Tested with tag 0.6.0 (needs sudo) and master branch (does not need sudo)

…msnif#59)

I decided to use a nested match statement for further handling
of the error, since it appears to be more rustesqe than a
if statement.
Copy link
Owner

@imsnif imsnif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm just doing some merges. Because of this: #49
We now swallow those errors.

We'll merge this and I'll move it to the right place. Sorry for the mess, lots of changes going on. :)

src/os/shared.rs Outdated Show resolved Hide resolved
Copy link
Owner

@imsnif imsnif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your work on this!

@imsnif imsnif merged commit 53dc3be into imsnif:master Jan 3, 2020
@Tobbeman Tobbeman deleted the enhancement/informative_error_not_sudo branch January 4, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show more informative error when run with insufficient (non-root) privileges
2 participants