Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #84 by handle error more gracefully #88

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fix issue #84 by handle error more gracefully #88

merged 1 commit into from
Jan 8, 2020

Conversation

zhangxp1998
Copy link
Collaborator

No description provided.

@zhangxp1998 zhangxp1998 force-pushed the io_error_wrapper branch 4 times, most recently from 0e625ed to 3e150bd Compare January 8, 2020 01:50
@zhangxp1998 zhangxp1998 requested a review from imsnif January 8, 2020 03:32
imsnif
imsnif approved these changes Jan 8, 2020
View reviewed changes
Copy link
Owner

@imsnif imsnif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - also tested locally (due to the untested linux parts) and it runs well.

Sorry for all the unwraps - you're definitely right and we should handle them better. This project became wide-spread rather surprisingly. :)

@zhangxp1998 zhangxp1998 merged commit c927ba9 into imsnif:master Jan 8, 2020
@zhangxp1998 zhangxp1998 deleted the io_error_wrapper branch January 8, 2020 17:07
@zhangxp1998 zhangxp1998 mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsnif imsnif imsnif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangxp1998 @imsnif