-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): update chart node-feature-discovery to 0.16.6 #172
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/node-feature-discovery-0.x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- HelmRelease: kube-system/node-feature-discovery ConfigMap: kube-system/node-feature-discovery-topology-updater-conf
+++ HelmRelease: kube-system/node-feature-discovery ConfigMap: kube-system/node-feature-discovery-topology-updater-conf
@@ -1,13 +0,0 @@
----
-apiVersion: v1
-kind: ConfigMap
-metadata:
- name: node-feature-discovery-topology-updater-conf
- namespace: kube-system
- labels:
- app.kubernetes.io/name: node-feature-discovery
- app.kubernetes.io/instance: node-feature-discovery
- app.kubernetes.io/managed-by: Helm
-data:
- nfd-topology-updater.conf: 'null'
-
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery
+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery
@@ -20,16 +20,24 @@
- list
- apiGroups:
- nfd.k8s-sigs.io
resources:
- nodefeatures
- nodefeaturerules
+ - nodefeaturegroups
verbs:
- get
- list
- watch
+- apiGroups:
+ - nfd.k8s-sigs.io
+ resources:
+ - nodefeaturegroups/status
+ verbs:
+ - patch
+ - update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
--- HelmRelease: kube-system/node-feature-discovery Role: kube-system/node-feature-discovery-worker
+++ HelmRelease: kube-system/node-feature-discovery Role: kube-system/node-feature-discovery-worker
@@ -14,7 +14,13 @@
resources:
- nodefeatures
verbs:
- create
- get
- update
+- apiGroups:
+ - ''
+ resources:
+ - pods
+ verbs:
+ - get
--- HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker
+++ HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker
@@ -7,12 +7,13 @@
labels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
app.kubernetes.io/managed-by: Helm
role: worker
spec:
+ revisionHistoryLimit: null
selector:
matchLabels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
role: worker
template:
@@ -22,23 +23,33 @@
app.kubernetes.io/instance: node-feature-discovery
role: worker
spec:
dnsPolicy: ClusterFirstWithHostNet
serviceAccountName: node-feature-discovery-worker
securityContext: {}
+ hostNetwork: false
containers:
- name: worker
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
imagePullPolicy: IfNotPresent
+ livenessProbe:
+ grpc:
+ port: 8082
+ initialDelaySeconds: 10
+ readinessProbe:
+ failureThreshold: 10
+ grpc:
+ port: 8082
+ initialDelaySeconds: 5
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: POD_NAME
@@ -46,20 +57,30 @@
fieldRef:
fieldPath: metadata.name
- name: POD_UID
valueFrom:
fieldRef:
fieldPath: metadata.uid
- resources: {}
+ resources:
+ limits:
+ memory: 512Mi
+ requests:
+ cpu: 5m
+ memory: 64Mi
command:
- nfd-worker
args:
+ - -feature-gates=NodeFeatureAPI=true
+ - -feature-gates=NodeFeatureGroupAPI=false
- -metrics=8081
+ - -grpc-health=8082
ports:
- - name: metrics
- containerPort: 8081
+ - containerPort: 8081
+ name: metrics
+ - containerPort: 8082
+ name: health
volumeMounts:
- name: host-boot
mountPath: /host-boot
readOnly: true
- name: host-os-release
mountPath: /host-etc/os-release
@@ -69,12 +90,15 @@
readOnly: true
- name: host-usr-lib
mountPath: /host-usr/lib
readOnly: true
- name: host-lib
mountPath: /host-lib
+ readOnly: true
+ - name: host-proc-swaps
+ mountPath: /host-proc/swaps
readOnly: true
- name: source-d
mountPath: /etc/kubernetes/node-feature-discovery/source.d/
readOnly: true
- name: features-d
mountPath: /etc/kubernetes/node-feature-discovery/features.d/
@@ -95,12 +119,15 @@
- name: host-usr-lib
hostPath:
path: /usr/lib
- name: host-lib
hostPath:
path: /lib
+ - name: host-proc-swaps
+ hostPath:
+ path: /proc/swaps
- name: source-d
hostPath:
path: /etc/kubernetes/node-feature-discovery/source.d/
- name: features-d
hostPath:
path: /etc/kubernetes/node-feature-discovery/features.d/
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master
+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master
@@ -8,12 +8,13 @@
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
app.kubernetes.io/managed-by: Helm
role: master
spec:
replicas: 1
+ revisionHistoryLimit: null
selector:
matchLabels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
role: master
template:
@@ -23,50 +24,59 @@
app.kubernetes.io/instance: node-feature-discovery
role: master
spec:
serviceAccountName: node-feature-discovery
enableServiceLinks: false
securityContext: {}
+ hostNetwork: false
containers:
- name: master
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
imagePullPolicy: IfNotPresent
livenessProbe:
grpc:
- port: 8080
+ port: 8082
initialDelaySeconds: 10
- periodSeconds: 10
readinessProbe:
+ failureThreshold: 10
grpc:
- port: 8080
+ port: 8082
initialDelaySeconds: 5
- periodSeconds: 10
- failureThreshold: 10
ports:
- containerPort: 8080
name: grpc
- containerPort: 8081
name: metrics
+ - containerPort: 8082
+ name: health
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
command:
- nfd-master
- resources: {}
+ resources:
+ limits:
+ memory: 4Gi
+ requests:
+ cpu: 100m
+ memory: 128Mi
args:
- -crd-controller=true
+ - -feature-gates=NodeFeatureAPI=true
+ - -feature-gates=NodeFeatureGroupAPI=false
- -metrics=8081
+ - -grpc-health=8082
volumeMounts:
- name: nfd-master-conf
mountPath: /etc/kubernetes/node-feature-discovery
readOnly: true
volumes:
- name: nfd-master-conf
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc
+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc
@@ -8,12 +8,13 @@
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
app.kubernetes.io/managed-by: Helm
role: gc
spec:
replicas: 1
+ revisionHistoryLimit: null
selector:
matchLabels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
role: gc
template:
@@ -23,26 +24,32 @@
app.kubernetes.io/instance: node-feature-discovery
role: gc
spec:
serviceAccountName: node-feature-discovery-gc
dnsPolicy: ClusterFirstWithHostNet
securityContext: {}
+ hostNetwork: false
containers:
- name: gc
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
imagePullPolicy: IfNotPresent
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
command:
- nfd-gc
args:
- -gc-interval=1h
- resources: {}
+ resources:
+ limits:
+ memory: 1Gi
+ requests:
+ cpu: 10m
+ memory: 128Mi
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
--- HelmRelease: kube-system/node-feature-discovery ServiceAccount: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ServiceAccount: kube-system/node-feature-discovery-prune
@@ -0,0 +1,14 @@
+---
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+ name: node-feature-discovery-prune
+ namespace: kube-system
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery-prune
@@ -0,0 +1,24 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+ name: node-feature-discovery-prune
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+rules:
+- apiGroups:
+ - ''
+ resources:
+ - nodes
+ - nodes/status
+ verbs:
+ - get
+ - patch
+ - update
+ - list
+
--- HelmRelease: kube-system/node-feature-discovery ClusterRoleBinding: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ClusterRoleBinding: kube-system/node-feature-discovery-prune
@@ -0,0 +1,21 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+ name: node-feature-discovery-prune
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+roleRef:
+ apiGroup: rbac.authorization.k8s.io
+ kind: ClusterRole
+ name: node-feature-discovery-prune
+subjects:
+- kind: ServiceAccount
+ name: node-feature-discovery-prune
+ namespace: kube-system
+
--- HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune
@@ -0,0 +1,66 @@
+---
+apiVersion: batch/v1
+kind: Job
+metadata:
+ name: node-feature-discovery-prune
+ namespace: kube-system
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+spec:
+ template:
+ metadata:
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ role: prune
+ spec:
+ serviceAccountName: node-feature-discovery-prune
+ containers:
+ - name: nfd-master
+ securityContext:
+ allowPrivilegeEscalation: false
+ capabilities:
+ drop:
+ - ALL
+ readOnlyRootFilesystem: true
+ runAsNonRoot: true
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
+ imagePullPolicy: IfNotPresent
+ command:
+ - nfd-master
+ args:
+ - -prune
+ restartPolicy: Never
+ affinity:
+ nodeAffinity:
+ preferredDuringSchedulingIgnoredDuringExecution:
+ - preference:
+ matchExpressions:
+ - key: node-role.kubernetes.io/master
+ operator: In
+ values:
+ - ''
+ weight: 1
+ - preference:
+ matchExpressions:
+ - key: node-role.kubernetes.io/control-plane
+ operator: In
+ values:
+ - ''
+ weight: 1
+ tolerations:
+ - effect: NoSchedule
+ key: node-role.kubernetes.io/master
+ operator: Equal
+ value: ''
+ - effect: NoSchedule
+ key: node-role.kubernetes.io/control-plane
+ operator: Equal
+ value: ''
+ |
--- kubernetes/apps/kube-system/node-feature-discovery/app Kustomization: flux-system/cluster-apps-node-feature-discovery HelmRelease: kube-system/node-feature-discovery
+++ kubernetes/apps/kube-system/node-feature-discovery/app Kustomization: flux-system/cluster-apps-node-feature-discovery HelmRelease: kube-system/node-feature-discovery
@@ -12,13 +12,13 @@
spec:
chart: node-feature-discovery
sourceRef:
kind: HelmRepository
name: node-feature-discovery
namespace: flux-system
- version: 0.15.1
+ version: 0.16.6
install:
crds: CreateReplace
remediation:
retries: 3
interval: 30m
maxHistory: 2 |
renovate
bot
changed the title
fix(helm): update chart node-feature-discovery to 0.15.3
fix(helm): update chart node-feature-discovery to 0.15.4
Apr 5, 2024
renovate
bot
force-pushed
the
renovate/node-feature-discovery-0.x
branch
from
April 5, 2024 13:55
b95151e
to
cd2c45e
Compare
renovate
bot
force-pushed
the
renovate/node-feature-discovery-0.x
branch
from
May 27, 2024 22:55
cd2c45e
to
9ca3efc
Compare
renovate
bot
changed the title
fix(helm): update chart node-feature-discovery to 0.15.4
feat(helm): update chart node-feature-discovery to 0.16.0
May 27, 2024
renovate
bot
force-pushed
the
renovate/node-feature-discovery-0.x
branch
from
July 3, 2024 17:00
9ca3efc
to
eaf6f6b
Compare
renovate
bot
changed the title
feat(helm): update chart node-feature-discovery to 0.16.0
feat(helm): update chart node-feature-discovery to 0.16.1
Jul 3, 2024
renovate
bot
force-pushed
the
renovate/node-feature-discovery-0.x
branch
from
July 11, 2024 12:10
eaf6f6b
to
6af14b6
Compare
renovate
bot
changed the title
feat(helm): update chart node-feature-discovery to 0.16.1
feat(helm): update chart node-feature-discovery to 0.16.2
Jul 11, 2024
renovate
bot
force-pushed
the
renovate/node-feature-discovery-0.x
branch
from
July 16, 2024 13:36
6af14b6
to
46ddca1
Compare
renovate
bot
changed the title
feat(helm): update chart node-feature-discovery to 0.16.2
feat(helm): update chart node-feature-discovery to 0.16.3
Jul 16, 2024
renovate
bot
force-pushed
the
renovate/node-feature-discovery-0.x
branch
from
August 12, 2024 12:40
46ddca1
to
4779f90
Compare
renovate
bot
changed the title
feat(helm): update chart node-feature-discovery to 0.16.3
feat(helm): update chart node-feature-discovery to 0.16.4
Aug 12, 2024
renovate
bot
changed the title
feat(helm): update chart node-feature-discovery to 0.16.4
feat(helm): update chart node-feature-discovery to 0.16.5
Oct 15, 2024
renovate
bot
force-pushed
the
renovate/node-feature-discovery-0.x
branch
from
October 15, 2024 09:46
4779f90
to
2c7f37b
Compare
renovate
bot
force-pushed
the
renovate/node-feature-discovery-0.x
branch
from
October 30, 2024 17:16
2c7f37b
to
319dc27
Compare
renovate
bot
changed the title
feat(helm): update chart node-feature-discovery to 0.16.5
feat(helm): update chart node-feature-discovery to 0.16.6
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.15.1
->0.16.6
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
kubernetes-sigs/node-feature-discovery (node-feature-discovery)
v0.16.6
Compare Source
What's Changed
Contributors @marquiz @elezar @ArangoGutierrez
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.5...v0.16.6
v0.16.5
Compare Source
What's Changed
Fixes an nfd-master memory leak on re-configure events when leader election is enabled. Adds parameters to configure health endpoint port.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.4...v0.16.5
v0.16.4
Compare Source
What's Changed
This patch release contains improvements to the Helm chart, adding configurable liveness and readiness probes for all daemons and configurable revision history limit for the nfd-worker and nfd-topology-updater.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.3...v0.16.4
v0.16.3
Compare Source
Fix detection of swap in some scenarios (#1751) and add Helm parameter to set the revisionHistoryLimit of nfd-master and nfd-gc (#1759).
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.2...v0.16.3
v0.16.2
Compare Source
What's Changed
Fixes an issue where node labels were temporarily removed on nfd-worker pod restarts.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.1...v0.16.2
v0.16.1
Compare Source
What's Changed
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1
v0.16.0
: v0.16Compare Source
Changelog
NodeFeatureGroup API
The NodeFeatureGroup custom resource was added to the NFD API. The NodeFeatureGroup API enables the creation of node groups based on features discovered by NFD. The API is an alpha feature and is disabled by default and can be enabled with the NodeFeatureGroupAPI feature gate.
See documentation for more details.
Feature gates
NFD adapted the concept of feature gates from Kubernetes to introduce and stabilize new features in a controlled way. See the documentation for more details. Two existing features (NodeFeature API and disabling label auto-prefixing) were converted into feature gates.
Deprecations
Upcoming changes
Support for hooks is deprecated since v0.12.0 and will be completely dropped in the NFD v0.17.
RDT feature labels removed
The
feature.node.kubernetes.io/cpu-rdt.*
feature labels that were deprecated in NFD v0.13 were removed. RDT features are still available for use in NodeFeatureRules for custom labels.Deprecated flags and options
The autoDefaultNs config file option of nfd-master is deprecated and will be removed in NFD v0.17. Superseded by the DisableAutoPrefix feature gate (
featureGates.DisableAutoPrefix
Helm parameter).The
-enable-nodefeature-api
command line flag of nfd-master and nfd-worker and the correspondingenableNodeFeatureApi
Helm chart parameter have been deprecated and will be removed in NFD v0.17. Superseded by the NodeFeature API feature gate (featureGates.NodeFeatureAPI
Helm parameter).The
-crd-controller
command line flag of nfd-master is deprecated and will be removed with the gRPC API in a future release.Miscellaneous
Network devices
Discover speed of virtual network interfaces.
DMI
Added support for detecting DMI attributes from
/sys/devices/virtual/dmi/id/
. In v0.16 onlysys_vendor
discovered, available assystem.dmiid.sys_vendor
feature for use in NodeFeatureRules.Swap
Discover the availability of swap on the node. Available as
memory.swap.enabled
feature for use in NodeFeatureRules.Helm chart
Now all nodes are cleaned up (feature labels, annotations, extended resources and taints are removed) after uninstalling NFD using a post-delete hook.
The Helm chart now sets resource requests (cpu and memory) for NFD pods. Users may want to adjust these for their cluster. An option to set the pod priority class was added. See Helm chart parameters in the documentation).
Container health
A gRPC health server was added to the nfd-master, nfd-worker and nfd-topology-updater daemons. Deployments (Helm and kustomize) configure container liveness and readiness probes to use that for health checking.
List of PRs
nfd-worker
erroring when reading attributes from paravirtual devices (#1557)v0.15.7
Compare Source
What's Changed
This patch release updates dependencies.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.6...v0.15.7
v0.15.6
Compare Source
What's Changed
Fixes an issue where node labels were temporarily removed on nfd-worker pod restarts.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.5...v0.15.6
v0.15.5
Compare Source
Changelog
This patch release fixes nfd-topology-updater on IPv6 clusters.
List of PRs
v0.15.4
Compare Source
This patch release fixes a potential crash in nfd-master (#1644).
v0.15.3
Compare Source
Changelog
This patch release fixes a critical memory leak in nfd-master, along with updating dependencies.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.2...v0.15.3
v0.15.2
Compare Source
Changelog
This release fixes a bug in hooks and updates dependencies.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.1...v0.15.2
Configuration
📅 Schedule: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.