Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): update chart node-feature-discovery to 0.16.6 #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 16, 2024

This PR contains the following updates:

Package Update Change
node-feature-discovery minor 0.15.1 -> 0.16.6

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

kubernetes-sigs/node-feature-discovery (node-feature-discovery)

v0.16.6

Compare Source

What's Changed

Contributors @​marquiz @​elezar @​ArangoGutierrez

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.5...v0.16.6

v0.16.5

Compare Source

What's Changed

Fixes an nfd-master memory leak on re-configure events when leader election is enabled. Adds parameters to configure health endpoint port.

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.4...v0.16.5

v0.16.4

Compare Source

What's Changed

This patch release contains improvements to the Helm chart, adding configurable liveness and readiness probes for all daemons and configurable revision history limit for the nfd-worker and nfd-topology-updater.

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.3...v0.16.4

v0.16.3

Compare Source

Fix detection of swap in some scenarios (#​1751) and add Helm parameter to set the revisionHistoryLimit of nfd-master and nfd-gc (#​1759).

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.2...v0.16.3

v0.16.2

Compare Source

What's Changed

Fixes an issue where node labels were temporarily removed on nfd-worker pod restarts.

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.1...v0.16.2

v0.16.1

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1

v0.16.0: v0.16

Compare Source

Changelog

NodeFeatureGroup API

The NodeFeatureGroup custom resource was added to the NFD API. The NodeFeatureGroup API enables the creation of node groups based on features discovered by NFD. The API is an alpha feature and is disabled by default and can be enabled with the NodeFeatureGroupAPI feature gate.

See documentation for more details.

Feature gates

NFD adapted the concept of feature gates from Kubernetes to introduce and stabilize new features in a controlled way. See the documentation for more details. Two existing features (NodeFeature API and disabling label auto-prefixing) were converted into feature gates.

Deprecations
Upcoming changes

Support for hooks is deprecated since v0.12.0 and will be completely dropped in the NFD v0.17.

RDT feature labels removed

The feature.node.kubernetes.io/cpu-rdt.* feature labels that were deprecated in NFD v0.13 were removed. RDT features are still available for use in NodeFeatureRules for custom labels.

Deprecated flags and options

The autoDefaultNs config file option of nfd-master is deprecated and will be removed in NFD v0.17. Superseded by the DisableAutoPrefix feature gate (featureGates.DisableAutoPrefix Helm parameter).

The -enable-nodefeature-api command line flag of nfd-master and nfd-worker and the corresponding enableNodeFeatureApi Helm chart parameter have been deprecated and will be removed in NFD v0.17. Superseded by the NodeFeature API feature gate (featureGates.NodeFeatureAPI Helm parameter).

The -crd-controller command line flag of nfd-master is deprecated and will be removed with the gRPC API in a future release.

Miscellaneous
Network devices

Discover speed of virtual network interfaces.

DMI

Added support for detecting DMI attributes from /sys/devices/virtual/dmi/id/. In v0.16 only sys_vendor discovered, available as system.dmiid.sys_vendor feature for use in NodeFeatureRules.

Swap

Discover the availability of swap on the node. Available as memory.swap.enabled feature for use in NodeFeatureRules.

Helm chart

Now all nodes are cleaned up (feature labels, annotations, extended resources and taints are removed) after uninstalling NFD using a post-delete hook.

The Helm chart now sets resource requests (cpu and memory) for NFD pods. Users may want to adjust these for their cluster. An option to set the pod priority class was added. See Helm chart parameters in the documentation).

Container health

A gRPC health server was added to the nfd-master, nfd-worker and nfd-topology-updater daemons. Deployments (Helm and kustomize) configure container liveness and readiness probes to use that for health checking.

List of PRs

  • github: update tagging instructions in release checklists (#​1527)
  • Update readme to v0.15.0 release (#​1524)
  • makefile: fix build: target (#​1528)
  • Makefile: add -timeout argument to e2e-tests (#​1526)
  • helm: add post-delete hook that cleans up the node (#​1532)
  • deployment/kustomize: drop the sample cert-manager overlay (#​1534)
  • nfd-master: run a separate gRPC health server (#​1535)
  • source/network: discover speed of virtual network interfaces (#​1536)
  • go.mod: update dependencies (#​1539)
  • chore: combine cpu count and thread_siblings functions into discover topology function (#​1505)
  • source/cpu: drop deprecated cpu-rdt labels (#​1530)
  • Update readme to v0.15.1 release (#​1552)
  • hack/generate: patch auto-generated deepcopy functions (#​1553)
  • apis/nfd: Trivial typo fix in tests (#​1537)
  • docs: update docs build dependencies (#​1543)
  • topology-updater: initialize properly with -no-publish (#​1554)
  • topology-updater: document the -no-publish flag correctly (#​1555)
  • Wrap nested errors (#​1558)
  • Prevent nfd-worker erroring when reading attributes from paravirtual devices (#​1557)
  • pkg/utils: move GetKubeconfig from pkg/apihelper here (#​1562)
  • OWNERS: add AhmedGrati as a reviewer (#​1564)
  • deployment/helm: don't deploy topology-updater conf unnecessarily (#​1565)
  • topology-updater: get topology api client directly (#​1566)
  • pkg/utils: move JsonPatch from pkg/apihelper (#​1568)
  • nfd-master: ditch apihelper (#​1570)
  • topology-updater: ditch apihelper (#​1567)
  • Drop pkg/apihelper (#​1561)
  • nfd-master: fix node status patching (#​1571)
  • nfd-topology-updater add pods fingerprint by default (#​1560)
  • docs: add KEP of Spiffe integration (#​1444)
  • docs: document removal of hooks in v0.17 (#​1573)
  • build(deps): bump github.com/opencontainers/runc from 1.1.10 to 1.1.12 (#​1575)
  • build(deps-dev): bump nokogiri from 1.16.0 to 1.16.2 in /docs (#​1576)
  • scripts/test-infra: bump golangci-lint to v1.56.1 (#​1580)
  • scripts/test-infra: bump k8s logcheck to v0.8.1 (#​1583)
  • Bump Go to v1.22 (#​1579)
  • scripts/test-infra: bump helm to v3.14.0 (#​1582)
  • source/kernel: add unit tests for kernel version parsing (#​1588)
  • helm: add priorityClassName option (#​1587)
  • source/pci: add unit test for the pci source (#​1589)
  • nfd-master: log errors on node update retries (#​1591)
  • source/system: Add reading vendor information (#​1574)
  • source/cpu: fix build tags on rdt discovery (#​1594)
  • helm: add ability to use a custom issuer (#​1598)
  • fix hook issue (#​1604)
  • generate: update autogenerate tools (#​1606)
  • apis/nfd/validate: use testify/assert for checking test results (#​1590)
  • Update readme to v0.15.2 release (#​1611)
  • Update generate scripts to use latest code_gen functions (#​1605)
  • nfd-master: mark the -crd-controller flag as deprecated (#​1612)
  • build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#​1613)
  • Use close to signal stop channedl in worker and topology-updater (#​1620)
  • nfd-master: fix memory leak in nfd api-controller (#​1615)
  • Update readme to v0.15.3 release (#​1628)
  • Add FeatureGate framework to handle new features (#​1623)
  • replace AhmedGrati account with TessaIO as reviewer (#​1630)
  • add swap support in nfd (#​1585)
  • nfd-master: check if node exists before trying update (#​1595)
  • Remove references to -enable-nodefeature-api flag (#​1632)
  • Add owner reference to NRT object (#​1602)
  • nfd-master: retry node updates indefinitely (#​1596)
  • nfd-worker: Add liveness probe (#​1609)
  • topology-updater: Set APIVersion, Kind in the OwnerReference explicitly (#​1634)
  • helm: fix invalid name of host-swaps volume (#​1635)
  • nfd-master: do nfd API scheme registration in an init function (#​1641)
  • chore/deployment: add resources requests and limits for helm and Kustomize (#​1631)
  • nfd-topology-updater: Add liveness probe (#​1643)
  • nfd-master: get node object only once when updating node (#​1652)
  • chore/deploy: make interval property in PodMonitor configurable (#​1639)
  • nfd-master: protect node updater pool queueing with a lock (#​1642)
  • nfd-master: prevent crash on empty config struct (#​1657)
  • Update readme to v0.15.4 release (#​1650)
  • Tidy up usage of channels for signaling (#​1656)
  • nfd-master: implement opts for modifying NfdMaster instance (#​1658)
  • nfd-master: parse kubeconfig even with NoPublish set (#​1655)
  • Move NFD api to a separate go mod (#​1600)
  • api/nfd: run go mod tidy (#​1661)
  • Fix Make generate (#​1662)
  • apis/nfd/validate: loosen validation of feature annotations (#​1633)
  • nfd-master: use separate k8s api clients for each updater (#​1653)
  • nfd-master: stop node-updater pool before reconfiguring api-controller (#​1660)
  • build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 (#​1665)
  • chore/nfd-master: remove warnings in nfd-master unit tests file (#​1668)
  • build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 in api/nfd (#​1666)
  • apis/nfd: add unit tests for match name functions (#​1667)
  • apis/nfd: no error on ops that never match (#​1670)
  • api/nfd: use varargs in the NewInstanceFeatures helper (#​1669)
  • scripts/test-infra: bump golangci-lint to v1.57.2 (#​1674)
  • add ARMv7 support (#​1659)
  • docs: document trade-offs in memory configuration (#​1651)
  • go.mod: bump kubernetes to v1.30 (#​1675)
  • cloudbuild.yaml: change machine type to e1-highcpu-32 (#​1678)
  • test/e2e: stop importing kubernetes test/e2e (#​1680)
  • hack/init-buildx.sh: fix broken patter matching (#​1683)
  • Disable armv7 builds (#​1677)
  • cloudbuild.yaml: downgrade machine type to e2-highcpu-8 (#​1685)
  • Update update_codegen.sh for v0.30 version of codegen tools (#​1681)
  • Dependabot: Add proper dependabot config file (#​1679)
  • build(deps): bump azure/setup-helm from 3 to 4 (#​1686)
  • build(deps): bump actions/checkout from 1 to 4 (#​1687)
  • build(deps): bump golang.org/x/net from 0.23.0 to 0.24.0 (#​1689)
  • build(deps): bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0 (#​1691)
  • build(deps): bump github.com/onsi/gomega from 1.31.0 to 1.33.0 (#​1692)
  • build(deps): bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.17.2 (#​1690)
  • build(deps): bump github.com/jaypipes/ghw from 0.8.1-0.20210827132705-c7224150a17e to 0.12.0 (#​1688)
  • apis/nfd: increase unit test coverage (#​1693)
  • build: specify buildx builder name everywhere (#​1684)
  • source/kernel: silence misleading error on selinux detection (#​1694)
  • build(deps): bump github.com/klauspost/cpuid/v2 from 2.2.6 to 2.2.7 (#​1695)
  • build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#​1696)
  • build(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 (#​1698)
  • build(deps): bump github.com/onsi/gomega from 1.33.0 to 1.33.1 (#​1699)
  • build(deps): bump github.com/k8stopologyawareschedwg/noderesourcetopology-api from 0.1.0 to 0.1.2 (#​1697)
  • build(deps): bump golang.org/x/net from 0.24.0 to 0.25.0 (#​1701)
  • build(deps): bump google.golang.org/grpc from 1.60.1 to 1.63.2 (#​1702)
  • build(deps-dev): bump nokogiri from 1.16.2 to 1.16.5 in /docs (#​1706)
  • build(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.1 (#​1703)
  • build(deps): bump github.com/k8stopologyawareschedwg/podfingerprint from 0.1.2 to 0.2.2 (#​1705)
  • nfd-master: add DisableAutoPrefix feature gate (#​1707)
  • Re-add -enable-nodefeature-api cmdline flag (#​1708)
  • build(deps): bump rexml from 3.2.6 to 3.2.8 in /docs (#​1709)
  • build(deps): bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3 (#​1711)
  • Add NodeFeatureGroup API (#​1487)
  • api/nfd: document all undocumented fields in the types (#​1714)
  • nfd-worker: improved log when creating NodeFeature object (#​1713)
  • apis/nfd: allow different types of features of the same name (#​1671)
  • cpu: advertise AVX10 version (#​1673)
  • source/cpu: disable AVX10 label (#​1715)
  • docs/helm: document all feature gates (#​1716)
  • build(deps): bump github.com/onsi/ginkgo/v2 from 2.17.3 to 2.19.0 (#​1717)
  • docs: add more cross-references to NodeFeatureGroup API (#​1718)

v0.15.7

Compare Source

What's Changed

This patch release updates dependencies.

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.6...v0.15.7

v0.15.6

Compare Source

What's Changed

Fixes an issue where node labels were temporarily removed on nfd-worker pod restarts.

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.5...v0.15.6

v0.15.5

Compare Source

Changelog

This patch release fixes nfd-topology-updater on IPv6 clusters.

List of PRs
  • go.mod: update dependencies (#​1676)
  • topology-updater: properly handle IPv6 from NODE_ADDRESS (#​1732)

v0.15.4

Compare Source

This patch release fixes a potential crash in nfd-master (#​1644).

v0.15.3

Compare Source

Changelog

This patch release fixes a critical memory leak in nfd-master, along with updating dependencies.

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.2...v0.15.3

v0.15.2

Compare Source

Changelog

This release fixes a bug in hooks and updates dependencies.

Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.1...v0.15.2


Configuration

📅 Schedule: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

github-actions bot commented Mar 16, 2024

--- HelmRelease: kube-system/node-feature-discovery ConfigMap: kube-system/node-feature-discovery-topology-updater-conf

+++ HelmRelease: kube-system/node-feature-discovery ConfigMap: kube-system/node-feature-discovery-topology-updater-conf

@@ -1,13 +0,0 @@

----
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: node-feature-discovery-topology-updater-conf
-  namespace: kube-system
-  labels:
-    app.kubernetes.io/name: node-feature-discovery
-    app.kubernetes.io/instance: node-feature-discovery
-    app.kubernetes.io/managed-by: Helm
-data:
-  nfd-topology-updater.conf: 'null'
-
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery

+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery

@@ -20,16 +20,24 @@

   - list
 - apiGroups:
   - nfd.k8s-sigs.io
   resources:
   - nodefeatures
   - nodefeaturerules
+  - nodefeaturegroups
   verbs:
   - get
   - list
   - watch
+- apiGroups:
+  - nfd.k8s-sigs.io
+  resources:
+  - nodefeaturegroups/status
+  verbs:
+  - patch
+  - update
 - apiGroups:
   - coordination.k8s.io
   resources:
   - leases
   verbs:
   - create
--- HelmRelease: kube-system/node-feature-discovery Role: kube-system/node-feature-discovery-worker

+++ HelmRelease: kube-system/node-feature-discovery Role: kube-system/node-feature-discovery-worker

@@ -14,7 +14,13 @@

   resources:
   - nodefeatures
   verbs:
   - create
   - get
   - update
+- apiGroups:
+  - ''
+  resources:
+  - pods
+  verbs:
+  - get
 
--- HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker

+++ HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker

@@ -7,12 +7,13 @@

   labels:
     app.kubernetes.io/name: node-feature-discovery
     app.kubernetes.io/instance: node-feature-discovery
     app.kubernetes.io/managed-by: Helm
     role: worker
 spec:
+  revisionHistoryLimit: null
   selector:
     matchLabels:
       app.kubernetes.io/name: node-feature-discovery
       app.kubernetes.io/instance: node-feature-discovery
       role: worker
   template:
@@ -22,23 +23,33 @@

         app.kubernetes.io/instance: node-feature-discovery
         role: worker
     spec:
       dnsPolicy: ClusterFirstWithHostNet
       serviceAccountName: node-feature-discovery-worker
       securityContext: {}
+      hostNetwork: false
       containers:
       - name: worker
         securityContext:
           allowPrivilegeEscalation: false
           capabilities:
             drop:
             - ALL
           readOnlyRootFilesystem: true
           runAsNonRoot: true
-        image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+        image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
         imagePullPolicy: IfNotPresent
+        livenessProbe:
+          grpc:
+            port: 8082
+          initialDelaySeconds: 10
+        readinessProbe:
+          failureThreshold: 10
+          grpc:
+            port: 8082
+          initialDelaySeconds: 5
         env:
         - name: NODE_NAME
           valueFrom:
             fieldRef:
               fieldPath: spec.nodeName
         - name: POD_NAME
@@ -46,20 +57,30 @@

             fieldRef:
               fieldPath: metadata.name
         - name: POD_UID
           valueFrom:
             fieldRef:
               fieldPath: metadata.uid
-        resources: {}
+        resources:
+          limits:
+            memory: 512Mi
+          requests:
+            cpu: 5m
+            memory: 64Mi
         command:
         - nfd-worker
         args:
+        - -feature-gates=NodeFeatureAPI=true
+        - -feature-gates=NodeFeatureGroupAPI=false
         - -metrics=8081
+        - -grpc-health=8082
         ports:
-        - name: metrics
-          containerPort: 8081
+        - containerPort: 8081
+          name: metrics
+        - containerPort: 8082
+          name: health
         volumeMounts:
         - name: host-boot
           mountPath: /host-boot
           readOnly: true
         - name: host-os-release
           mountPath: /host-etc/os-release
@@ -69,12 +90,15 @@

           readOnly: true
         - name: host-usr-lib
           mountPath: /host-usr/lib
           readOnly: true
         - name: host-lib
           mountPath: /host-lib
+          readOnly: true
+        - name: host-proc-swaps
+          mountPath: /host-proc/swaps
           readOnly: true
         - name: source-d
           mountPath: /etc/kubernetes/node-feature-discovery/source.d/
           readOnly: true
         - name: features-d
           mountPath: /etc/kubernetes/node-feature-discovery/features.d/
@@ -95,12 +119,15 @@

       - name: host-usr-lib
         hostPath:
           path: /usr/lib
       - name: host-lib
         hostPath:
           path: /lib
+      - name: host-proc-swaps
+        hostPath:
+          path: /proc/swaps
       - name: source-d
         hostPath:
           path: /etc/kubernetes/node-feature-discovery/source.d/
       - name: features-d
         hostPath:
           path: /etc/kubernetes/node-feature-discovery/features.d/
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master

+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master

@@ -8,12 +8,13 @@

     app.kubernetes.io/name: node-feature-discovery
     app.kubernetes.io/instance: node-feature-discovery
     app.kubernetes.io/managed-by: Helm
     role: master
 spec:
   replicas: 1
+  revisionHistoryLimit: null
   selector:
     matchLabels:
       app.kubernetes.io/name: node-feature-discovery
       app.kubernetes.io/instance: node-feature-discovery
       role: master
   template:
@@ -23,50 +24,59 @@

         app.kubernetes.io/instance: node-feature-discovery
         role: master
     spec:
       serviceAccountName: node-feature-discovery
       enableServiceLinks: false
       securityContext: {}
+      hostNetwork: false
       containers:
       - name: master
         securityContext:
           allowPrivilegeEscalation: false
           capabilities:
             drop:
             - ALL
           readOnlyRootFilesystem: true
           runAsNonRoot: true
-        image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+        image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
         imagePullPolicy: IfNotPresent
         livenessProbe:
           grpc:
-            port: 8080
+            port: 8082
           initialDelaySeconds: 10
-          periodSeconds: 10
         readinessProbe:
+          failureThreshold: 10
           grpc:
-            port: 8080
+            port: 8082
           initialDelaySeconds: 5
-          periodSeconds: 10
-          failureThreshold: 10
         ports:
         - containerPort: 8080
           name: grpc
         - containerPort: 8081
           name: metrics
+        - containerPort: 8082
+          name: health
         env:
         - name: NODE_NAME
           valueFrom:
             fieldRef:
               fieldPath: spec.nodeName
         command:
         - nfd-master
-        resources: {}
+        resources:
+          limits:
+            memory: 4Gi
+          requests:
+            cpu: 100m
+            memory: 128Mi
         args:
         - -crd-controller=true
+        - -feature-gates=NodeFeatureAPI=true
+        - -feature-gates=NodeFeatureGroupAPI=false
         - -metrics=8081
+        - -grpc-health=8082
         volumeMounts:
         - name: nfd-master-conf
           mountPath: /etc/kubernetes/node-feature-discovery
           readOnly: true
       volumes:
       - name: nfd-master-conf
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc

+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc

@@ -8,12 +8,13 @@

     app.kubernetes.io/name: node-feature-discovery
     app.kubernetes.io/instance: node-feature-discovery
     app.kubernetes.io/managed-by: Helm
     role: gc
 spec:
   replicas: 1
+  revisionHistoryLimit: null
   selector:
     matchLabels:
       app.kubernetes.io/name: node-feature-discovery
       app.kubernetes.io/instance: node-feature-discovery
       role: gc
   template:
@@ -23,26 +24,32 @@

         app.kubernetes.io/instance: node-feature-discovery
         role: gc
     spec:
       serviceAccountName: node-feature-discovery-gc
       dnsPolicy: ClusterFirstWithHostNet
       securityContext: {}
+      hostNetwork: false
       containers:
       - name: gc
-        image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+        image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
         imagePullPolicy: IfNotPresent
         env:
         - name: NODE_NAME
           valueFrom:
             fieldRef:
               fieldPath: spec.nodeName
         command:
         - nfd-gc
         args:
         - -gc-interval=1h
-        resources: {}
+        resources:
+          limits:
+            memory: 1Gi
+          requests:
+            cpu: 10m
+            memory: 128Mi
         securityContext:
           allowPrivilegeEscalation: false
           capabilities:
             drop:
             - ALL
           readOnlyRootFilesystem: true
--- HelmRelease: kube-system/node-feature-discovery ServiceAccount: kube-system/node-feature-discovery-prune

+++ HelmRelease: kube-system/node-feature-discovery ServiceAccount: kube-system/node-feature-discovery-prune

@@ -0,0 +1,14 @@

+---
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: node-feature-discovery-prune
+  namespace: kube-system
+  labels:
+    app.kubernetes.io/name: node-feature-discovery
+    app.kubernetes.io/instance: node-feature-discovery
+    app.kubernetes.io/managed-by: Helm
+  annotations:
+    helm.sh/hook: post-delete
+    helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery-prune

+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery-prune

@@ -0,0 +1,24 @@

+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: node-feature-discovery-prune
+  labels:
+    app.kubernetes.io/name: node-feature-discovery
+    app.kubernetes.io/instance: node-feature-discovery
+    app.kubernetes.io/managed-by: Helm
+  annotations:
+    helm.sh/hook: post-delete
+    helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+rules:
+- apiGroups:
+  - ''
+  resources:
+  - nodes
+  - nodes/status
+  verbs:
+  - get
+  - patch
+  - update
+  - list
+
--- HelmRelease: kube-system/node-feature-discovery ClusterRoleBinding: kube-system/node-feature-discovery-prune

+++ HelmRelease: kube-system/node-feature-discovery ClusterRoleBinding: kube-system/node-feature-discovery-prune

@@ -0,0 +1,21 @@

+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+  name: node-feature-discovery-prune
+  labels:
+    app.kubernetes.io/name: node-feature-discovery
+    app.kubernetes.io/instance: node-feature-discovery
+    app.kubernetes.io/managed-by: Helm
+  annotations:
+    helm.sh/hook: post-delete
+    helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: node-feature-discovery-prune
+subjects:
+- kind: ServiceAccount
+  name: node-feature-discovery-prune
+  namespace: kube-system
+
--- HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune

+++ HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune

@@ -0,0 +1,66 @@

+---
+apiVersion: batch/v1
+kind: Job
+metadata:
+  name: node-feature-discovery-prune
+  namespace: kube-system
+  labels:
+    app.kubernetes.io/name: node-feature-discovery
+    app.kubernetes.io/instance: node-feature-discovery
+    app.kubernetes.io/managed-by: Helm
+  annotations:
+    helm.sh/hook: post-delete
+    helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+spec:
+  template:
+    metadata:
+      labels:
+        app.kubernetes.io/name: node-feature-discovery
+        app.kubernetes.io/instance: node-feature-discovery
+        app.kubernetes.io/managed-by: Helm
+        role: prune
+    spec:
+      serviceAccountName: node-feature-discovery-prune
+      containers:
+      - name: nfd-master
+        securityContext:
+          allowPrivilegeEscalation: false
+          capabilities:
+            drop:
+            - ALL
+          readOnlyRootFilesystem: true
+          runAsNonRoot: true
+        image: registry.k8s.io/nfd/node-feature-discovery:v0.16.6
+        imagePullPolicy: IfNotPresent
+        command:
+        - nfd-master
+        args:
+        - -prune
+      restartPolicy: Never
+      affinity:
+        nodeAffinity:
+          preferredDuringSchedulingIgnoredDuringExecution:
+          - preference:
+              matchExpressions:
+              - key: node-role.kubernetes.io/master
+                operator: In
+                values:
+                - ''
+            weight: 1
+          - preference:
+              matchExpressions:
+              - key: node-role.kubernetes.io/control-plane
+                operator: In
+                values:
+                - ''
+            weight: 1
+      tolerations:
+      - effect: NoSchedule
+        key: node-role.kubernetes.io/master
+        operator: Equal
+        value: ''
+      - effect: NoSchedule
+        key: node-role.kubernetes.io/control-plane
+        operator: Equal
+        value: ''
+

Copy link

github-actions bot commented Mar 16, 2024

--- kubernetes/apps/kube-system/node-feature-discovery/app Kustomization: flux-system/cluster-apps-node-feature-discovery HelmRelease: kube-system/node-feature-discovery

+++ kubernetes/apps/kube-system/node-feature-discovery/app Kustomization: flux-system/cluster-apps-node-feature-discovery HelmRelease: kube-system/node-feature-discovery

@@ -12,13 +12,13 @@

     spec:
       chart: node-feature-discovery
       sourceRef:
         kind: HelmRepository
         name: node-feature-discovery
         namespace: flux-system
-      version: 0.15.1
+      version: 0.16.6
   install:
     crds: CreateReplace
     remediation:
       retries: 3
   interval: 30m
   maxHistory: 2

@renovate renovate bot changed the title fix(helm): update chart node-feature-discovery to 0.15.3 fix(helm): update chart node-feature-discovery to 0.15.4 Apr 5, 2024
@renovate renovate bot force-pushed the renovate/node-feature-discovery-0.x branch from b95151e to cd2c45e Compare April 5, 2024 13:55
@renovate renovate bot force-pushed the renovate/node-feature-discovery-0.x branch from cd2c45e to 9ca3efc Compare May 27, 2024 22:55
@renovate renovate bot changed the title fix(helm): update chart node-feature-discovery to 0.15.4 feat(helm): update chart node-feature-discovery to 0.16.0 May 27, 2024
@renovate renovate bot force-pushed the renovate/node-feature-discovery-0.x branch from 9ca3efc to eaf6f6b Compare July 3, 2024 17:00
@renovate renovate bot changed the title feat(helm): update chart node-feature-discovery to 0.16.0 feat(helm): update chart node-feature-discovery to 0.16.1 Jul 3, 2024
@renovate renovate bot force-pushed the renovate/node-feature-discovery-0.x branch from eaf6f6b to 6af14b6 Compare July 11, 2024 12:10
@renovate renovate bot changed the title feat(helm): update chart node-feature-discovery to 0.16.1 feat(helm): update chart node-feature-discovery to 0.16.2 Jul 11, 2024
@renovate renovate bot force-pushed the renovate/node-feature-discovery-0.x branch from 6af14b6 to 46ddca1 Compare July 16, 2024 13:36
@renovate renovate bot changed the title feat(helm): update chart node-feature-discovery to 0.16.2 feat(helm): update chart node-feature-discovery to 0.16.3 Jul 16, 2024
@renovate renovate bot force-pushed the renovate/node-feature-discovery-0.x branch from 46ddca1 to 4779f90 Compare August 12, 2024 12:40
@renovate renovate bot changed the title feat(helm): update chart node-feature-discovery to 0.16.3 feat(helm): update chart node-feature-discovery to 0.16.4 Aug 12, 2024
@renovate renovate bot changed the title feat(helm): update chart node-feature-discovery to 0.16.4 feat(helm): update chart node-feature-discovery to 0.16.5 Oct 15, 2024
@renovate renovate bot force-pushed the renovate/node-feature-discovery-0.x branch from 4779f90 to 2c7f37b Compare October 15, 2024 09:46
@renovate renovate bot force-pushed the renovate/node-feature-discovery-0.x branch from 2c7f37b to 319dc27 Compare October 30, 2024 17:16
@renovate renovate bot changed the title feat(helm): update chart node-feature-discovery to 0.16.5 feat(helm): update chart node-feature-discovery to 0.16.6 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants