Add non-breaking LPSPI rework #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
Co-authored-by: Ian McIntyre <ianpmcintyre@gmail.com>
- Make sure we never get a baud rate faster than specified (slower is pretty much always ok for peripherals) - Configure PCSSCK and SCKPCS properly for contiguous transfers
Co-authored-by: Ian McIntyre <ianpmcintyre@gmail.com>
Co-authored-by: Ian McIntyre <ianpmcintyre@gmail.com>
Currently non-breaking, and we encourage users towards the Lpspi::set_mode method. This allows us to avoid the RMW on TCR, which the reference manual says isn't best. Co-authored-by: Ian McIntyre <ianpmcintyre@gmail.com>
Unlike LPUART, there's no requirement to be disabled while changing this. Keep the existing API, and point users towards the new method. Co-authored-by: Ian McIntyre <ianpmcintyre@gmail.com>
|
looked good to me, glad to see it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are most of the non-breaking changes proposed in #149. I extracted them so that we could test and release them with today's driver. Unless there's concern, I plan to publish these within the 0.5 releases.