-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Implement plugin system for archivists' parsers
This commit introduces a flexible plugin system for archivists' parsers, allowing new parsers to be registered dynamically. The system utilizes an initialization function that registers parsers via a `Register` function. The primary changes include: - Creation of `parser_registry.go` to handle parser registration and storage. - Modification of `parserstorer.go` to integrate the new parser registration system and utilize registered parsers during attestation storage. This system enhances the extensibility of the parser functionality and improves maintainability by decoupling the parser registration from the core logic. Changes: - Added `internal/metadatastorage/attestationcollection/parser_registry.go` for parser registration. - Updated `internal/metadatastorage/attestationcollection/parserstorer.go` to support the new plugin system. Signed-off-by: Frederick F. Kautz IV <frederick@testifysec.com>
- Loading branch information
Showing
2 changed files
with
47 additions
and
3 deletions.
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
pkg/metadatastorage/attestationcollection/parser_registry.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// Copyright 2024 The Archivista Contributors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package attestationcollection | ||
|
||
import ( | ||
"context" | ||
"encoding/json" | ||
"github.com/in-toto/archivista/ent" | ||
"log" | ||
) | ||
|
||
var registeredParsers map[string]AttestationParser | ||
|
||
func init() { | ||
registeredParsers = make(map[string]AttestationParser) | ||
} | ||
|
||
func Register(attestationType string, parser AttestationParser) { | ||
registeredParsers[attestationType] = parser | ||
log.Printf("parser registered: %s", attestationType) | ||
} | ||
|
||
type AttestationParser func(ctx context.Context, tx *ent.Tx, attestation *ent.Attestation, attestationType string, message json.RawMessage) error |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters