add jenkins attestor #323
Merged
add jenkins attestor #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to follow conventional commits. This will help to get the change into the changelog too. |
|
Could you clarify what you mean by conventional commits? |
|
You can read up on it here in the contribution doc. https://github.com/in-toto/go-witness/blob/main/CONTRIBUTING.md |
jkjell
force-pushed
the
jenkins-attestor
branch
from
c347081
to
97f17be
Compare
joshdabosh
force-pushed
the
jenkins-attestor
branch
from
97f17be
to
35d6257
Compare
jkjell
requested changes
Aug 13, 2024
There was a problem hiding this comment.
This looks great @joshdabosh! Thanks for submitting this. No comments on the current content of the PR but, it would be good to add some tests. If you could add a jenkins_test.go for the attestor and add a test case to the slsa_test.go that should be enough.
joshdabosh
force-pushed
the
jenkins-attestor
branch
from
9575031
to
50fe5c3
Compare
Signed-off-by: JoshDaBosh <jwanggt@gmail.com>
Signed-off-by: JoshDaBosh <jwanggt@gmail.com>
jkjell
force-pushed
the
jenkins-attestor
branch
from
41cff7a
to
0a5f168
Compare
jkjell
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add a Jenkins build attestor. We can use it in the SLSA provenance data as well, which currently only supports Github Actions and Gitlab CI.
This will allow us to capture data related to a Jenkins build without having to capture the entire scope of environment variables (in case there is sensitive data in the environment).
Which issue(s) this PR fixes (optional)
Closes #315
Acceptance Criteria Met
Special notes for your reviewer: