Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update key to signer-file-key-path in getting starter .witness.yaml #288

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

blhagadorn
Copy link
Contributor

A recent update changed the value for the key location from key to signer-file-key-path, this updates the Getting Started portion to reflect that change:
See https://github.com/testifysec/witness/pull/276/files#diff-a2d81e76a54ef2f17702a8b6de2fac6a61330f3585b3204f0463b3fa880c0f70L16
and current open issue: #287

@blhagadorn blhagadorn changed the title Update key to signer-file-key-path in getting starter .witness.yaml Update key to signer-file-key-path in Getting Started .witness.yaml Oct 21, 2023
@blhagadorn blhagadorn changed the title Update key to signer-file-key-path in Getting Started .witness.yaml [docs] Update key to signer-file-key-path in Getting Started .witness.yaml Oct 21, 2023
@blhagadorn
Copy link
Contributor Author

@mikhailswift I don't think I have permission to add a reviewer, would you be the right person to tag? Thanks

@mikhailswift
Copy link
Member

Hi @blhagadorn , thanks for this! John or I are good people to tag for these things. We appreciate the catch on our out of date documentation here.

@mikhailswift
Copy link
Member

This is a minor nit, but can you amend your commit message to be inline with the conventional commit spec?

docs: Update key to signer-file-key-path in getting starter .witness.yaml

would be perfect

@blhagadorn blhagadorn changed the title [docs] Update key to signer-file-key-path in Getting Started .witness.yaml docs: Update key to signer-file-key-path in getting starter .witness.yaml Oct 23, 2023
…yaml

Signed-off-by: Bryant Hagadorn <blhagadorn@gmail.com>
@mikhailswift
Copy link
Member

Sorry for the confusion, I meant the git commit message not the issue title

You should be able to do

git commit --amend and re-word your commit message that way. This will require a git push --force, though. If you'd like I can handle cherry-picking your commit and rewording it, you'll still be the author of the commit :)

@blhagadorn blhagadorn force-pushed the updateGettingStarted branch from a3a4a2c to 939f8be Compare October 23, 2023 19:26
@blhagadorn
Copy link
Contributor Author

no problem, done

@mikhailswift
Copy link
Member

Thank you!

@mikhailswift mikhailswift merged commit edef808 into in-toto:main Oct 23, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants