feat: add algo hash list for digest calc in config #292
Conversation
DataDavD
force-pushed
the
feat/ISSUE-73/add-digest-algos-to-config
branch
from
32d3c10 to
58a49da
Compare
|
hey @mikhailswift not sure I understand why the failed pipelines are failing for |
|
The failures are from the way GHA treats the permissions on that token when running from a PR from a fork. We're working on a fix to the actions and will hopefully have something soon! |
|
Got it. No rush. Thank you 🙏 Cheers, |
|
@DataDavD Looks like everything is passing now besides the doc gen. You can run this locally with |
|
Thanks! I'm out of the country but will do this first thing when I return at the end of the month. |
jkjell
force-pushed
the
feat/ISSUE-73/add-digest-algos-to-config
branch
from
126a27b to
01ff9ea
Compare
DataDavD
force-pushed
the
feat/ISSUE-73/add-digest-algos-to-config
branch
from
01ff9ea to
6b97fa3
Compare
|
I just updated. Thanks again @jkjell. |
Introduce cobra/config flag that allows for slice of string's indicating hash algorithms to be used for digest calculation. Uses go-witness.attestation.WithHashes to add the slice to attestation run options. Will error if can't parse hash from its string value. Add test for testing acceptable/unacceptable hash algorithms accepted. Refs: in-toto#73
jkjell
force-pushed
the
feat/ISSUE-73/add-digest-algos-to-config
branch
from
6b97fa3 to
3fac8af
Compare
|
Thanks @DataDavD |
|
No problem! Very happy to help! Thanks for letting me contribute to your great project! |
Introduce flag that allows for slice of string's indicating hash algorithms to be used for digest calculation. Uses go-witness.attestation.WithHashes to add the slice to attestation run options. Will error if can't parse hash from its string value.
Add to run tests to test for acceptable/unacceptable hash algorithms accepted
Refs: #73