Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Verify Error Response #430

Merged
merged 14 commits into from
May 10, 2024
Merged

Improving Verify Error Response #430

merged 14 commits into from
May 10, 2024

Conversation

ChaosInTheCRD
Copy link
Collaborator

No description provided.

@ChaosInTheCRD
saving changes to client
1ba8ffd 
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for witness-project canceled.

Name Link
🔨 Latest commit ac10dda
🔍 Latest deploy log https://app.netlify.com/sites/witness-project/deploys/663e47ab322c5c00088191ce

matglas
matglas reviewed Apr 30, 2024
View reviewed changes
cmd/verify.go Outdated Show resolved Hide resolved
@ChaosInTheCRD
switching error logs to be error returns (should ensure exit 1 is exit
9970630 
status)

Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@ChaosInTheCRD
Merge branch 'main' into improve-verify-errors
6388fc9
@ChaosInTheCRD
changing failure statement to match changes in go-witness
be848b5 
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@ChaosInTheCRD
fixing go mod
ec353c2 
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@ChaosInTheCRD
Merge branch 'improve-verify-errors' of github.com:ChaosInTheCRD/witn…
e69916d 
…ess into improve-verify-errors

Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@ChaosInTheCRD
adding check for a source
5e3ed0f 
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@ChaosInTheCRD ChaosInTheCRD mentioned this pull request May 8, 2024
Closed
5 tasks
@ChaosInTheCRD
Copy link
Collaborator Author

ChaosInTheCRD commented May 10, 2024 •
edited
Loading

I need to get this PR inline with https://github.com/in-toto/go-witness/tree/main

@ChaosInTheCRD
getting things up to scratch
702384c 
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@ChaosInTheCRD
Merge branch 'main' into improve-verify-errors
cfa3e26 
Signed-off-by: Tom Meadows <tom@tmlabs.co.uk>
@ChaosInTheCRD
go mod tidy and a small fix
5ef815a 
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@ChaosInTheCRD ChaosInTheCRD marked this pull request as ready for review May 10, 2024 16:11
@ChaosInTheCRD
fixing bool comparison lint issue
ac10dda 
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@jkjell jkjell merged commit d866f90 into in-toto:main May 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matglas matglas matglas left review comments

@jkjell jkjell jkjell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaosInTheCRD @jkjell @matglas