Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repetitive and incorrect log lines on witness verify #317 #485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChaosInTheCRD
Copy link
Collaborator

@ChaosInTheCRD ChaosInTheCRD commented Aug 1, 2024

What this PR does / why we need it

some cleanup around in-toto/go-witness#317.

  • It seemed as though we might be adding the memory source even if we don't specify an attestation-file-path so I have cleaned it up a bit.
  • improved the general logging after verify.

testing instructions for @Xopek from in-toto/go-witness#316:

  • clone and checkout this branch and the corresponding go-witness branch
  • add a replace line to go.mod in this repository to point to your local go-witness repository:
module github.com/in-toto/witness

go 1.22.0

toolchain go1.22.2

++ replace github.com/in-toto/go-witness => <path/to/local/go-witness>
  • run go mod tidy
  • test with go run . run and go run . verify in the root of this branch.

Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for witness-project ready!

Name Link
🔨 Latest commit d91794b
🔍 Latest deploy log https://app.netlify.com/sites/witness-project/deploys/66abb31fb9ca7a0008db8ca8
😎 Deploy Preview https://deploy-preview-485--witness-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xopek
Copy link

Xopek commented Aug 7, 2024

Can confirm, that this fixed issue in-toto/go-witness#316.

However for some reason in order for "verify" command to work, i had to regenerate attestations, without it verify failed with error:

ERROR   Verification failed
ERROR   Evidence:
ERROR   Step: build
ERROR   verification failure: no collections found
ERROR   failed to verify policy: policy verification failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants