Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add results about permutations #42

Merged
merged 13 commits into from
May 27, 2024
Merged

Add results about permutations #42

merged 13 commits into from
May 27, 2024

Conversation

lczielinski
Copy link
Collaborator

Author: @wjbs

Add many results to Permutations.v, necessary for defining ZXPerm in VyZX. Results about:

  • injectivity/surjectivity of permutations
  • permutation inverse
  • well-foundedness of permutatinos
  • stacking permutations
  • swaps of elements
  • permutations on lists
    ...and some automation.

@lczielinski lczielinski requested a review from adrianleh May 5, 2024 23:23
lczielinski
lczielinski commented May 5, 2024
View reviewed changes
coq-quantumlib.opam Outdated Show resolved Hide resolved
adrianleh
adrianleh requested changes May 17, 2024
View reviewed changes
Copy link
Member

@adrianleh adrianleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Some very useful additions are in here. I left some inline comments for changes that we might want to make.

Prelim.v Outdated Show resolved Hide resolved
VectorStates.v Outdated Show resolved Hide resolved
coq-quantumlib.opam Outdated Show resolved Hide resolved
Permutations.v Show resolved Hide resolved
Permutations.v Outdated Show resolved Hide resolved
Permutations.v Outdated Show resolved Hide resolved
Permutations.v Outdated Show resolved Hide resolved
Permutations.v Outdated Show resolved Hide resolved
coq-quantumlib.opam Outdated Show resolved Hide resolved
@adrianleh
Copy link
Member

@lczielinski We also want to bump the version in dune-project and coq-quantumlib.opam to 1.5.0

@lczielinski lczielinski requested a review from adrianleh May 27, 2024 19:20
@lczielinski
Copy link
Collaborator Author

Made new files Bits.v (the classical bit stuff from VectorStates.v), PermutationAutomation.v (the second half of Permutation.v) and Modulus.v (a few lemmas about mod)

adrianleh
adrianleh approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@adrianleh adrianleh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianleh adrianleh merged commit ee147b9 into main May 27, 2024
4 checks passed
@adrianleh adrianleh deleted the permutations branch May 27, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianleh adrianleh adrianleh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lczielinski @adrianleh @wjbs