[Fix #26] Fix static_files trail #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| StaticFiles = | ||
| case application:get_env(cowboy_swagger, static_files) of | ||
| {ok, Val} -> Val; | ||
| _ -> SwaggerPrivDir |
There was a problem hiding this comment.
The idea of evaluating cowboy_swagger_priv() here, instead of doing StaticFiles = application:get_env(cowboy_swagger, static_files, cowboy_swagger_priv()) was to avoid the evaluation of said function if it wasn't actually needed. So, you should either do
StaticFiles = application:get_env(cowboy_swagger, static_files, cowboy_swagger_priv())if you don't think we need to optimize that code just yet or…
case application:get_env(cowboy_swagger, static_files) of
{ok, Val} -> Val;
_ -> filename:join(cowboy_swagger_priv(), "swagger"),
end…if you do ;)
There was a problem hiding this comment.
@elbrujohalcon You're right, let me change it.
elbrujohalcon
pushed a commit
that referenced
this pull request
Nov 27, 2015
…variable-is-not-good-for-releases [Fix #26] Fix static_files trail
elbrujohalcon
deleted the
harenson.26.static-files-as-an-env-variable-is-not-good-for-releases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And upgrades trails dependency