Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure gen_statem follows the same rule as gen_server #128

Merged
merged 5 commits into from
Sep 9, 2020
Merged

Make sure gen_statem follows the same rule as gen_server #128

merged 5 commits into from
Sep 9, 2020

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

No description provided.

@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Sep 8, 2020
Closed
@elbrujohalcon
Copy link
Member

Travis is not happy, @paulo-ferraz-oliveira :P

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Travis is not happy, @paulo-ferraz-oliveira :P

Let me check what it's complaining about. Tests pass locally, at least.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Hm... I seem to have called handle_event handle_call. Tests don't fail, though, locally, so there's something I'm missing here.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

A bit outside the scope of this, I took the liberty to update Travis CI instructions, to deal with more Erlang/OTP versions.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I'm now running the same as Travis CI runs (I added a Makefile and a ct target to it) and can see the issues show up. This is better than having to wait for GitHub to tell me where I got stuff wrong.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Travis is not happy, @paulo-ferraz-oliveira :P

Travis is no longer angry at me.

elbrujohalcon
elbrujohalcon approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine, but I would like to eventually simplify our travis integration, to something like this since there is support for rebar3 on Travis now.

@elbrujohalcon elbrujohalcon merged commit 2c129ed into inaka:master Sep 9, 2020
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/gen_statem_in_state_record_and_type branch September 9, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elbrujohalcon elbrujohalcon elbrujohalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulo-ferraz-oliveira @elbrujohalcon