read_watersurfaces(): support version watersurfaces_v1.2 and optionally fix geometries #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that some upstream changes from iconv() also come in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from updated data, for version
watersurfaces_v1.2an extra variablewater_level_managementis returned. See inbo/n2khab-preprocessing#64 for an exploration of this data source version.read_watersurfaces()now optionally fixes invalid or corrupt geometries (logical argumentfix_geom; default isFALSE), implementing inbo/n2khab-preprocessing#60 (comment). This applies to all versions, and should be used when generating derived data sources.@ToonHub, @cecileherr or others, feel free to review.