Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codespell: config, workflow and have typos fixed #64

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

yarikoptic
Copy link
Member

No description provided.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@pep8speaks
Copy link

Hello @yarikoptic! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 328:80: E501 line too long (91 > 79 characters)

Line 55:80: E501 line too long (108 > 79 characters)

@Remi-Gau
Copy link
Contributor

@yarikoptic
have you set some sort of global "just_run_add_codespell" to all repos

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually can you add a precommit for codespell as well?

@yarikoptic
Copy link
Member Author

indeed! the crude script (https://github.com/yarikoptic/improveit/blob/main/codespellit) would have added it if there was a pre-commit in this repo... but it saw no config

@Remi-Gau
Copy link
Contributor

OK will take care of the precommit thing in another PR

@Remi-Gau Remi-Gau merged commit f9d5ec5 into incf-nidash:master Feb 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants