Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] update packaging #65

Merged
merged 13 commits into from
Feb 20, 2024
Merged

[MAINT] update packaging #65

merged 13 commits into from
Feb 20, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 19, 2024


  • move from setup.py to pyproject.toml
  • move CLI scripts
  • use only README.md
  • run tests with tox
  • drop python 3.7 and test on 3.12

@pep8speaks
Copy link

pep8speaks commented Feb 19, 2024

Hello @Remi-Gau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:19: W292 no newline at end of file

Line 32:80: E501 line too long (86 > 79 characters)
Line 59:80: E501 line too long (88 > 79 characters)

Line 2:80: E501 line too long (90 > 79 characters)
Line 24:80: E501 line too long (86 > 79 characters)

Comment last updated at 2024-02-20 07:42:37 UTC

pyproject.toml Outdated Show resolved Hide resolved
@Remi-Gau
Copy link
Contributor Author

Error on python 3.12 as the imp module got dropped from the standard library

 Traceback (most recent call last):
  File "/home/runner/work/nidmresults/nidmresults/test/test_reader.py", line 9, in <module>
    from nidmresults.owl.owl_reader import OwlReader
  File "/home/runner/work/nidmresults/nidmresults/.tox/tests/lib/python3.12/site-packages/nidmresults/owl/owl_reader.py", line 22, in <module>
    from future.standard_library import hooks
  File "/home/runner/work/nidmresults/nidmresults/.tox/tests/lib/python3.12/site-packages/future/standard_library/__init__.py", line 65, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'

@Remi-Gau Remi-Gau merged commit d482b20 into incf-nidash:master Feb 20, 2024
1 check passed
@Remi-Gau Remi-Gau deleted the packaging branch February 20, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants