Skip to content

Commit

Permalink
Fix bug with equality that meant diff failed
Browse files Browse the repository at this point in the history
We were always updating everything because we had an incorrect equality
check. Things are the same if ranks are equal, and different if they are
not.
  • Loading branch information
lawrencejones committed Jul 3, 2023
1 parent a368a89 commit 4eb8054
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion reconcile/entries.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ func Entries(ctx context.Context, logger kitlog.Logger, cl EntriesClient, catalo
if entry != nil {
isSame :=
entry.Name == model.Name &&
reflect.DeepEqual(entry.Aliases, model.Aliases) && entry.Rank != model.Rank
reflect.DeepEqual(entry.Aliases, model.Aliases) && entry.Rank == model.Rank

currentBindings := map[string]client.CatalogAttributeBindingPayloadV2{}
for attributeID, value := range entry.AttributeValues {
Expand Down

0 comments on commit 4eb8054

Please sign in to comment.