Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix falling tests #23

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Fix falling tests #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15e44dc
Change image url
Feb 8, 2024
484b343
Change test execution conditions
Feb 8, 2024
36f86c5
Add Ruby related paths to gitignore
Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Test

on:
pull_request:
push:
types: [opened, synchronize, reopened, ready_for_review]
workflow_dispatch:
schedule:
- cron: "0 1 * * 1" # At 01:00 (UTC) / 10:00 (JST) on Monday
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ node_modules
tmp/camouflage.pid
tmp/camo.pid
.node-version

.bundle
.ruby-version
vendor
4 changes: 2 additions & 2 deletions test/proxy_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_proxy_survives_redirect_without_location
end
end

response = request('http://media.ebaumsworld.com/picture/Mincemeat/Pimp.jpg')
response = request('https://qiita-image-store.s3.ap-northeast-1.amazonaws.com/0/55950/dee6d393-c8a2-887a-889e-1cf4ebd3896a.png')
assert_equal(200, response.code)
end

Expand Down Expand Up @@ -80,7 +80,7 @@ def test_always_sets_security_headers
end

def test_proxy_valid_image_url
response = request('http://media.ebaumsworld.com/picture/Mincemeat/Pimp.jpg')
response = request('https://qiita-image-store.s3.ap-northeast-1.amazonaws.com/0/55950/dee6d393-c8a2-887a-889e-1cf4ebd3896a.png')
assert_equal(200, response.code)
end

Expand Down
Loading