Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump husky from 9.0.10 to 9.0.11 #131

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 8, 2024

Bumps husky from 9.0.10 to 9.0.11.

Release notes

Sourced from husky's releases.

v9.0.11

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [husky](https://github.com/typicode/husky) from 9.0.10 to 9.0.11.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v9.0.10...v9.0.11)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 8, 2024
@dependabot dependabot bot requested review from a team and kimkim0814 and removed request for a team April 8, 2024 05:46
@kimkim0814
Copy link
Member

今回はパッチの変更のみで、破壊的変更はなし

@kimkim0814
Copy link
Member

kimkim0814 commented Apr 10, 2024

📝
コミットを行い、huskyの動作確認を行った。
今回は、使用しないhogeという定数を定義した上でコミットした。

qiita-cli % git cm -m "test"
yarn run v1.22.19
$ /Users/user_name/Documents/project/qiita-cli/node_modules/.bin/lint-staged
✔ Preparing lint-staged...
❯ Running tasks for staged files...
  ❯ package.json — 1 file
    ❯ *.{js,ts,tsx} — 1 file
      ✖ yarn run lint:eslint:fix [FAILED]
    ✔ * — 1 file
↓ Skipped because of errors from tasks. [SKIPPED]
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...

✖ yarn run lint:eslint:fix:
error Command failed with exit code 1.
$ eslint --fix /Users/user_name/Documents/project/qiita-cli/src/commands/pull.ts

/Users/user_name/Documents/project/qiita-cli/src/commands/pull.ts
  15:9  error  'hoge' is assigned a value but never used  @typescript-eslint/no-unused-vars

✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
husky - pre-commit hook exited with code 1 (error)

期待した通りに、lint-stagedでコミットが弾かれた

Copy link
Member

@kimkim0814 kimkim0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kimkim0814 kimkim0814 requested review from a team and acronhub and removed request for a team April 10, 2024 03:11
Copy link
Contributor

@acronhub acronhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acronhub acronhub merged commit 6526398 into main Apr 12, 2024
6 checks passed
@acronhub acronhub deleted the dependabot/npm_and_yarn/husky-9.0.11 branch April 12, 2024 02:05
@ohakutsu ohakutsu mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants