Use hashbrown's new single-lookup insertion #263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
find_or_find_insert_slot
andinsert_in_slot
, we can avoid anextra insertion lookup after checking for existence. However, that also
reserves space for a new entry before checking existence, so it's a
little biased towards new items. For that reason, we're not using this
for map
entry
or setreplace
, as both imply a little more weight onthe expectation that it may already exist.