Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add GitHub Actions workflow #63

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

MikeMcC399
Copy link
Contributor

Issue

Existing CI workflows are outdated and non-functional:

Change

Add workflow .github/workflows/ci-test.yml

  • which triggers on push or pull_request

  • runs on GitHub Actions latest runners ubuntu-24.04, windows-2022 and macos-14 using

  • currently supported Node.js versions 18, 20, 22 and 23

  • and runs

    • npm test
    • npm run coverage

@MikeMcC399
Copy link
Contributor Author

The workflow ran successfully in https://github.com/MikeMcC399/ps-tree/actions/runs/12279885394

Copy link
Collaborator

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399 good additions. 👌
Thanks. 🙏

Note: we could also remove the .travis.yml and .appveyor.yml files as these are no longer working/needed. ✂️

@nelsonic nelsonic merged commit c97da69 into indexzero:master Dec 12, 2024
@MikeMcC399 MikeMcC399 deleted the add/ci-github-action branch December 12, 2024 07:54
@MikeMcC399
Copy link
Contributor Author

@nelsonic

Note: we could also remove the .travis.yml and .appveyor.yml files as these are no longer working/needed. ✂️

This would be an action for the repo maintainers, as the accounts on Travis and AppVeyor would also need to be deleted, which can't be done through a PR. Also the build badge Build Status in the README, which uses Travis, should be removed or updated to use the results of the GitHub Actions CI workflow.

@MikeMcC399
Copy link
Contributor Author

@nelsonic

I have submitted two additional PRs:

The action to clean up the CI accounts still needs to be done by maintainers with access to the accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Actions (CI)?
2 participants